Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/watchflakes: adjust behavior for non-default branches #59483

Open
2 tasks
bcmills opened this issue Apr 7, 2023 · 3 comments
Open
2 tasks

x/build/cmd/watchflakes: adjust behavior for non-default branches #59483

bcmills opened this issue Apr 7, 2023 · 3 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 7, 2023

When watchflakes posts to an issue (as in #58714 (comment)), it gives the timestamp and Go commit hash but not the Go branch name.

For failures on release branches that occur after an attempted fix, the branch name is a very important detail: it helps us figure out whether the fix was successful (and may need to be backported) or unsuccessful (and needs to be further revised).

Specifically, I suggest that when watchflakes posts newly-identified test flakes:

  • the summary lines for failures on non-default branches should mention the branch name, and
  • watchflakes should not reopen a closed issue if the only new failures are on non-default branches.

(attn @cherrymui; CC @golang/release)

@bcmills bcmills added this to the Unreleased milestone Apr 7, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 7, 2023
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 7, 2023
@cherrymui
Copy link
Member

Thanks. Will do.

@cherrymui cherrymui self-assigned this Apr 7, 2023
@cherrymui
Copy link
Member

The tricky part is that the dashboard on the subrepo doesn't have any information about the branch of the main repo. So watchflakes doesn't see it easily. (In fact, watchflakes already has the logic to print a different text, but GoBranch is never set...)

watchflakes could deduce a go commit's branch from the dashboard of the main repo on that branch. That will need more work.

@bcmills
Copy link
Contributor Author

bcmills commented Apr 21, 2023

Yep. The other options would be to change the dashboard to populate more data, or to have watchflakes separately load data from maintner (as I did for greplogs --triage back when).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants