Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: cannot call SetType(go.shape.int) on v (type int) [1.20 backport] #59450

Closed
gopherbot opened this issue Apr 5, 2023 · 2 comments
Closed

cmd/compile: internal compiler error: cannot call SetType(go.shape.int) on v (type int) [1.20 backport] #59450

gopherbot opened this issue Apr 5, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.4

Comments

@gopherbot
Copy link

@cuonglm requested issue #59378 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport this issue to go1.20, this causes code that use standard package slices stop compiling with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 5, 2023
@gopherbot gopherbot mentioned this issue Apr 5, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 5, 2023
@gopherbot gopherbot added this to the Go1.20.4 milestone Apr 5, 2023
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Apr 5, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 5, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/482655 mentions this issue: [release-branch.go1.20] cmd/compile: don't set range expr key/value type if already set

gopherbot pushed a commit that referenced this issue Apr 5, 2023
@cuonglm @gopherbot
[release-branch.go1.20] cmd/compile: don't set range expr key/value t…
99001c4 
…ype if already set

Unified IR already records the correct type for them.

Fixes #59450

Change-Id: I275c45b48f67bde55c8e2079d60b5868d0acde7f
Reviewed-on: https://go-review.googlesource.com/c/go/+/481555
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/482655
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Author

Closed by merging 99001c4 to release-branch.go1.20.

bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@cuonglm @bradfitz
[release-branch.go1.20] cmd/compile: don't set range expr key/value t…
285505b 
…ype if already set

Unified IR already records the correct type for them.

Fixes golang#59450

Change-Id: I275c45b48f67bde55c8e2079d60b5868d0acde7f
Reviewed-on: https://go-review.googlesource.com/c/go/+/481555
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/482655
Auto-Submit: Michael Knyszek <mknyszek@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@cuonglm @bradfitz
[release-branch.go1.20] cmd/compile: don't set range expr key/value t…
9ea2b72 
…ype if already set

Unified IR already records the correct type for them.

Fixes golang#59450

Change-Id: I275c45b48f67bde55c8e2079d60b5868d0acde7f
Reviewed-on: https://go-review.googlesource.com/c/go/+/481555
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/482655
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.4
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot