Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportRemovesDeadIdleConnections failures #59438

Closed
gopherbot opened this issue Apr 4, 2023 · 3 comments
Closed

net/http: TestTransportRemovesDeadIdleConnections failures #59438

gopherbot opened this issue Apr 4, 2023 · 3 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Apr 4, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRemovesDeadIdleConnections" && `expected a different connection`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportRemovesDeadIdleConnections (0.00s)
    --- FAIL: TestTransportRemovesDeadIdleConnections/h1 (0.05s)
        transport_test.go:775: expected a different connection between requests. got "127.0.0.1:57295" both times

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRemovesDeadIdleConnections"
2023-04-04 16:59 dragonfly-amd64-622 go@20374d1d net/http.TestTransportRemovesDeadIdleConnections (log) 
--- FAIL: TestTransportRemovesDeadIdleConnections (0.00s)
    --- FAIL: TestTransportRemovesDeadIdleConnections/h1 (0.05s)
        transport_test.go:775: expected a different connection between requests. got "127.0.0.1:57295" both times

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Apr 4, 2023

I think this test is just bogus. It is assuming that the port used for the first connection will not be reused when dialing the second connection.

(CC @neild)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Apr 4, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/482175 mentions this issue: net/http: drop client address comparison in TestTransportRemovesDeadIdleConnections

@bcmills bcmills added this to the Go1.21 milestone Apr 4, 2023
@bcmills bcmills self-assigned this Apr 5, 2023
@golang golang locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot