x/tools/go/ssa: function.Origin() panics with "index out of range" #59427

aykevl · 2023-04-04T10:58:42Z

What version of Go are you using (`go version`)?

$ go version
go version go1.20.2 darwin/arm64

Does this issue reproduce with the latest release?

Yes, 1.20.2 is the latest release.

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN="/Users/ayke/bin"
GOCACHE="/Users/ayke/Library/Caches/go-build"
GOENV="/Users/ayke/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/ayke/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/ayke/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.20.2/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.20.2/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.2"
GCCGO="gccgo"
AR="ar"
CC="cc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/Users/ayke/src/ayke/sandbox/ssabug/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/17/btmpymwj0wv6n50cmslwyr900000gn/T/go-build3633563543=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

To reproduce:

clone https://github.com/aykevl/sandbox
go to the ssabug subdirectory
run go run .

What did you expect to see?

I expected .Origin() (last line of the program) to return something sensible.

What did you see instead?

It panics. Here is the complete output of the program, including all debug prints:

~/src/ayke/sandbox/ssabug$ go run .
Test: ssabug/testa.Test
# Name: ssabug/testa.Test
# Package: ssabug/testa
# Location: /Users/ayke/src/ayke/sandbox/ssabug/testa/testa.go:7:6
func Test():
0:                                                                entry P:0 S:0
	t0 = ssabug/value.Map[int]()                 ssabug/value.ValueItf[int]
	return

map call: ssabug/value.Map[int]()
map fn: ssabug/value.Map[int]
# Name: ssabug/value.Map[int]
# Synthetic: instance of Map
# Location: /Users/ayke/src/ayke/sandbox/ssabug/value/value.go:16:6
func Map[int]() ValueItf[int]:
0:                                                                entry P:0 S:0
	t0 = new Mapper[int] (complit)                             *Mapper[int]
	t1 = make ValueItf[int] <- *Mapper[int] (t0)              ValueItf[int]
	return t1

make inst: make ValueItf[int] <- *Mapper[int] (t0)
method: (*ssabug/value.Mapper[int]).Get[int]
# Name: (*ssabug/value.Mapper[int]).Get[int]
# Synthetic: instance of Get
# Location: /Users/ayke/src/ayke/sandbox/ssabug/value/value.go:11:21
func (m *Mapper[int]) Get[int](fn func()):
0:                                                                entry P:0 S:0
	t0 = &m.V [#0]                                           *ValueItf[int]
	t1 = *t0                                                  ValueItf[int]
	t2 = invoke t1.Get((*Mapper[int]).Get[int]$1)                        ()
	return

param: (*ssabug/value.Mapper[int]).Get[int]$1
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
golang.org/x/tools/go/ssa.(*Function).Origin(0x140002d6a80)
	/Users/ayke/go/pkg/mod/golang.org/x/tools@v0.7.0/go/ssa/ssa.go:1543 +0x70
main.readPackage(0x140002d4080)
	/Users/ayke/src/ayke/sandbox/ssabug/main.go:58 +0x400
main.main()
	/Users/ayke/src/ayke/sandbox/ssabug/main.go:31 +0x180
exit status 2

Note: I have also found a race condition when working with two SSA packages in a sing
le *ssa.Program that contains generics, but haven't been able to create a solid reproducer yet. I do feel like this bug could be related to that race condition.

Original issue found in tinygo-org/tinygo#3593.

The text was updated successfully, but these errors were encountered:

mknyszek · 2023-04-04T14:17:54Z

CC @golang/tools-team

timothy-king · 2023-05-02T04:38:05Z

IIUC the key issue seems to be that in the test, the following happens:

ssa.Packages ssabug/testa and ssabug/value are created.
testa imports value.
testa is pkg.Build() value is not pkg.Build().
InstantiateGenerics is on.
value.Map[int]() is built. So (*ssabug/value.Mapper[int]).Get[int] is built too.
The test then asks for the Origin of (*ssabug/value.Mapper[int]).Get[int]$1.
(*ssabug/value.Mapper[T]).Get[T]$1 has not been built and its body & AnonFuncs list is empty.
There is the seen array out of bounds access.

This can be resolved by making sure the "value" package is built before asking for the Origin. Or by building the ssa.Program.

I think my question is what are you hoping for the "sensible" output to be? Are you hoping to get nil as the result? Are you hoping for the "value" package to get built if you happened to request this? A more user friendly panic message?

FWIW are you sure you do not want to build value as a stub package? (See buildssa for how to do this.) You would not have the body of (*ssabug/value.Mapper[int]).Get[int] either if this is how this was built.

Note: I have also found a race condition when working with two SSA packages in a single *ssa.Program that contains generics, but haven't been able to create a solid reproducer yet.

I'll be happy to take a look once you have more info.

aykevl · 2023-05-02T13:00:57Z

Thank you for investigating!

I think my question is what are you hoping for the "sensible" output to be? Are you hoping to get nil as the result? Are you hoping for the "value" package to get built if you happened to request this? A more user friendly panic message?

I am not entirely sure. At the very least, a more useful panic message would go a long way. Also, documentation that says how this case should be handled would be helpful, something like "Origin() on a function instantiated from a different package needs to have that package already built" - not sure how to phrase this correctly.

FWIW are you sure you do not want to build value as a stub package? (See buildssa for how to do this.) You would not have the body of (*ssabug/value.Mapper[int]).Get[int] either if this is how this was built.

Hmm, perhaps I need to do this. I think the last time I tried this I ran into some issues, but I can try again.

What I really want is to get the AST node from which the generic function was built. Unfortunately, Syntax() returns nil on instantiated functions. Hence why I need to call Origin() to get the generic function so I can call Syntax(). If Origin() doesn't work across packages, then I don't think there is an API to do what I want. Do you have any suggestions?

Note: I have also found a race condition when working with two SSA packages in a single *ssa.Program that contains generics, but haven't been able to create a solid reproducer yet.

I'll be happy to take a look once you have more info.

I'm pretty sure this is a related bug, as I build the programs in parallel (which means that one pkg.Build() might not be finished before another package starts accessing its generic functions - this works fine outside generics). But if it's still present after I find a fix for the index out of range panic, then I can file a separate bug.

gopherbot · 2023-05-02T21:42:03Z

Change https://go.dev/cl/491735 mentions this issue: go/ssa: keep syntax for instantiations

gopherbot · 2023-05-02T22:18:50Z

Change https://go.dev/cl/491755 mentions this issue: go/ssa: Origin is only available after building

aykevl · 2023-05-02T22:43:17Z

Building the dependencies first indeed appears to fix the problem. It does complicate the build a little bit though.

Keep the Syntax() for function instantiations when the origin package has debug info enabled. Updates golang/go#59427 Change-Id: I0a2a6ad2abbcec8226ef044510926dae33a2471a Reviewed-on: https://go-review.googlesource.com/c/tools/+/491735 Run-TryBot: Tim King <taking@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>

aykevl · 2023-09-26T18:58:33Z

Note: I have also found a race condition when working with two SSA packages in a single *ssa.Program that contains generics, but haven't been able to create a solid reproducer yet.

I'll be happy to take a look once you have more info.

I have finally managed to make a reproducer for this race condition, and made a bug report here: #63247

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 4, 2023

gopherbot added this to the Unreleased milestone Apr 4, 2023

aykevl mentioned this issue Apr 4, 2023

compiler: support pragmas on generic functions tinygo-org/tinygo#3593

Open

mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2023

timothy-king self-assigned this Apr 6, 2023

gopherbot closed this as completed in golang/tools@479f5c6 May 5, 2023

aykevl mentioned this issue Jun 1, 2023

Race condition tinygo-org/tinygo#3532

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/go/ssa: function.Origin() panics with "index out of range" #59427

x/tools/go/ssa: function.Origin() panics with "index out of range" #59427

aykevl commented Apr 4, 2023

mknyszek commented Apr 4, 2023

timothy-king commented May 2, 2023

aykevl commented May 2, 2023

gopherbot commented May 2, 2023

gopherbot commented May 2, 2023

aykevl commented May 2, 2023

aykevl commented Sep 26, 2023

x/tools/go/ssa: function.Origin() panics with "index out of range" #59427

x/tools/go/ssa: function.Origin() panics with "index out of range" #59427

Comments

aykevl commented Apr 4, 2023

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

mknyszek commented Apr 4, 2023

timothy-king commented May 2, 2023

aykevl commented May 2, 2023

gopherbot commented May 2, 2023

gopherbot commented May 2, 2023

aykevl commented May 2, 2023

aykevl commented Sep 26, 2023

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?