Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/screentest: TestReadTest failing since 2023-03-31 #59402

Closed
bcmills opened this issue Apr 3, 2023 · 1 comment
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 3, 2023

https://build.golang.org/log/355b0c1358c968d0a3943b76e3dc0a85e8e756f7:

--- FAIL: TestReadTests (0.00s)
    --- FAIL: TestReadTests/test (0.00s)
        screentest_test.go:191: readTests() mismatch (-want +got):
              []*screentest.testcase{
              	&{name: "go.dev homepage", urlA: "https://go.dev/", urlB: "http://localhost:6060/go.dev/", status: 200, ...},
              	&{name: "go.dev homepage 540x1080", urlA: "https://go.dev/", urlB: "http://localhost:6060/go.dev/", status: 200, ...},
              	&{name: "about page", urlA: "https://go.dev/about", urlB: "http://localhost:6060/go.dev/about", status: 200, ...},
              	&{
              		name: "pkg.go.dev homepage .go-Carousel",
            - 		tasks: chromedp.Tasks{
            - 			&chromedp.Selector{
            - 				sel:   string(".go-Carousel-dot"),
            - 				exp:   1,
            - 				by:    ⟪0x7d2620⟫,
            - 				wait:  ⟪0x7d33f0⟫,
            - 				after: ⟪0x7e68d0⟫,
            - 			},
            - 		},
            + 		tasks: chromedp.Tasks{
            + 			&chromedp.Selector{
            + 				sel:   string(".go-Carousel-dot"),
            + 				exp:   1,
            + 				by:    ⟪0x7d2620⟫,
            + 				wait:  ⟪0x7d33f0⟫,
            + 				after: ⟪0x7e0550⟫,
            + 			},
            + 		},
              		urlA: "https://pkg.go.dev/",
              		urlB: "https://beta.pkg.go.dev/",
              		... // 1 ignored and 13 identical fields
              	},
              	&{name: "net package doc", tasks: {&chromedp.Selector{sel: string(`[role="treeitem"][aria-expanded=`...), exp: 1, by: ⟪0x7d2620⟫, wait: ⟪0x7d2890⟫}}, urlA: "https://pkg.go.dev/net", urlB: "https://beta.pkg.go.dev/net", ...},
              	&{name: "net package doc 540x1080", tasks: {&chromedp.Selector{sel: string(`[role="treeitem"][aria-expanded=`...), exp: 1, by: ⟪0x7d2620⟫, wait: ⟪0x7d2890⟫}}, urlA: "https://pkg.go.dev/net", urlB: "https://beta.pkg.go.dev/net", ...},
              	&{name: "about", urlA: "https://pkg.go.dev/about", urlB: "http://localhost:8080/about", headers: {"Authorization": string("Bearer token")}, ...},
              	&{
              		name:  "eval",
            - 		tasks: chromedp.Tasks{chromedp.ActionFunc(⟪0x7e6750⟫)},
            + 		tasks: chromedp.Tasks{chromedp.ActionFunc(⟪0x7e03d0⟫)},
              		urlA:  "https://pkg.go.dev/eval",
              		urlB:  "http://localhost:8080/eval",
              		... // 1 ignored and 13 identical fields
              	},
              	&{name: "gcs-output", urlA: "https://pkg.go.dev/gcs-output", urlB: "http://localhost:8080/gcs-output", headers: {"Authorization": string("Bearer token")}, ...},
              }
FAIL
FAIL	golang.org/x/website/internal/screentest	0.133s

The first failure on the dashboard was at main-repo CL 451356, but I don't see how that could produce this failure mode. The last passing run prior to that was at CL 462202, and the commits in between were skipped by the coordinator. Since the failure appears to be deterministic, a good starting point might be to git bisect that interval of main-repo commits.

(attn @jamalc; CC @golang/tools-team)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) website labels Apr 3, 2023
@bcmills bcmills added this to the Unreleased milestone Apr 3, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Apr 3, 2023

Funky! This seems to have been fixed, possibly by CL 481637?

That would suggest CL 479095 as the initial regression (CC @golang/runtime).

@bcmills bcmills removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Apr 3, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@golang golang locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Development

No branches or pull requests

2 participants