Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/test: TestPGOIntendedInliningShiftedLines failures #59395

Closed
gopherbot opened this issue Apr 3, 2023 · 2 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "cmd/compile/internal/test" && test == "TestPGOIntendedInliningShiftedLines"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPGOIntendedInliningShiftedLines (18.62s)
    pgo_inl_test.go:99: child: # example.com/pgo/inline [example.com/pgo/inline.test]
    pgo_inl_test.go:99: child: ./inline_hot.go:26:6: can inline D with cost 7 as: func(uint) int { return int((i + (wSize - 1)) >> lWSize) }
    pgo_inl_test.go:99: child: ./inline_hot.go:30:6: can inline N with cost 20 as: func(uint) *BS { bs = &BS{...}; return bs }
    pgo_inl_test.go:99: child: ./inline_hot.go:33:19: inlining call to D
    pgo_inl_test.go:99: child: ./inline_hot.go:39:6: can inline (*BS).S with cost 14 as: method(*BS) func(uint) *BS { b.s[i >> lWSize] |= 1 << (i & (wSize - 1)); return b }
    pgo_inl_test.go:99: child: ./inline_hot.go:51:6: can inline T with cost 12 as: func(uint64) uint { return uint(jn[v & -v * 0x03f79d71b4ca8b09 >> 58]) }
    pgo_inl_test.go:99: child: ./inline_hot.go:55:6: can inline (*BS).NS with cost 106 as: method(*BS) func(uint) (uint, bool) { x := int(i >> lWSize); if x >= len(b.s) { return 0, false }; w := b.s[x]; w = w >> (i & (wSize - 1)); if w != 0 { return i + T(w), true }; x = x + 1; for loop; return 0, false }
    pgo_inl_test.go:99: child: ./inline_hot.go:63:15: inlining call to T
    pgo_inl_test.go:99: child: ./inline_hot.go:68:28: inlining call to T
...
    pgo_inl_test.go:99: child: r12    0xe94c90
    pgo_inl_test.go:99: child: r13    0xfffffc7feed6c300
    pgo_inl_test.go:99: child: r14    0xe5ec60
    pgo_inl_test.go:99: child: r15    0x0
    pgo_inl_test.go:99: child: rip    0xfffffc7fef1f7f47
    pgo_inl_test.go:99: child: rflags 0x247
    pgo_inl_test.go:99: child: cs     0x53
    pgo_inl_test.go:99: child: fs     0x0
    pgo_inl_test.go:99: child: gs     0x0
    pgo_inl_test.go:132: error running go test: exit status 2

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/compile/internal/test" && test == "TestPGOIntendedInliningShiftedLines"
2023-03-14 13:17 illumos-amd64 go@035db07d cmd/compile/internal/test.TestPGOIntendedInliningShiftedLines (log)
--- FAIL: TestPGOIntendedInliningShiftedLines (18.62s)
    pgo_inl_test.go:99: child: # example.com/pgo/inline [example.com/pgo/inline.test]
    pgo_inl_test.go:99: child: ./inline_hot.go:26:6: can inline D with cost 7 as: func(uint) int { return int((i + (wSize - 1)) >> lWSize) }
    pgo_inl_test.go:99: child: ./inline_hot.go:30:6: can inline N with cost 20 as: func(uint) *BS { bs = &BS{...}; return bs }
    pgo_inl_test.go:99: child: ./inline_hot.go:33:19: inlining call to D
    pgo_inl_test.go:99: child: ./inline_hot.go:39:6: can inline (*BS).S with cost 14 as: method(*BS) func(uint) *BS { b.s[i >> lWSize] |= 1 << (i & (wSize - 1)); return b }
    pgo_inl_test.go:99: child: ./inline_hot.go:51:6: can inline T with cost 12 as: func(uint64) uint { return uint(jn[v & -v * 0x03f79d71b4ca8b09 >> 58]) }
    pgo_inl_test.go:99: child: ./inline_hot.go:55:6: can inline (*BS).NS with cost 106 as: method(*BS) func(uint) (uint, bool) { x := int(i >> lWSize); if x >= len(b.s) { return 0, false }; w := b.s[x]; w = w >> (i & (wSize - 1)); if w != 0 { return i + T(w), true }; x = x + 1; for loop; return 0, false }
    pgo_inl_test.go:99: child: ./inline_hot.go:63:15: inlining call to T
    pgo_inl_test.go:99: child: ./inline_hot.go:68:28: inlining call to T
...
    pgo_inl_test.go:99: child: r12    0xe94c90
    pgo_inl_test.go:99: child: r13    0xfffffc7feed6c300
    pgo_inl_test.go:99: child: r14    0xe5ec60
    pgo_inl_test.go:99: child: r15    0x0
    pgo_inl_test.go:99: child: rip    0xfffffc7fef1f7f47
    pgo_inl_test.go:99: child: rflags 0x247
    pgo_inl_test.go:99: child: cs     0x53
    pgo_inl_test.go:99: child: fs     0x0
    pgo_inl_test.go:99: child: gs     0x0
    pgo_inl_test.go:132: error running go test: exit status 2

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Apr 3, 2023

Duplicate of #59379

@bcmills bcmills marked this as a duplicate of #59379 Apr 3, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@golang golang locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants