Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cmd/test: TestPrepareRename failures #59358

Closed
gopherbot opened this issue Apr 1, 2023 · 2 comments
Closed

x/tools/gopls/internal/lsp/cmd/test: TestPrepareRename failures #59358

gopherbot opened this issue Apr 1, 2023 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestPrepareRename"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPrepareRename (28.89s)
    integration_test.go:556: gopls prepare_rename a.go:1:9: stderr does not match [can't rename package]; got <<2023/03/31 23:30:28 internal error unmarshalling *[]cache.gobDiagnostic: invalid character '\x00' looking for beginning of value
        >>
    integration_test.go:561: gopls prepare_rename a.go:2:9: exited with code 1, want success: true (gopls prepare_rename a.go:2:9: exit=1 stdout=<<./a.go:2:6-13
        >> stderr=<<2023/03/31 23:30:34 internal error unmarshalling *[]cache.gobDiagnostic: invalid character '\x00' looking for beginning of value
        >>)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 1, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestPrepareRename"
2023-03-31 19:13 darwin-amd64-nocgo tools@65208701 go@99276aeb x/tools/gopls/internal/lsp/cmd/test.TestPrepareRename (log) 
--- FAIL: TestPrepareRename (28.89s)
    integration_test.go:556: gopls prepare_rename a.go:1:9: stderr does not match [can't rename package]; got <<2023/03/31 23:30:28 internal error unmarshalling *[]cache.gobDiagnostic: invalid character '\x00' looking for beginning of value
        >>
    integration_test.go:561: gopls prepare_rename a.go:2:9: exited with code 1, want success: true (gopls prepare_rename a.go:2:9: exit=1 stdout=<<./a.go:2:6-13
        >> stderr=<<2023/03/31 23:30:34 internal error unmarshalling *[]cache.gobDiagnostic: invalid character '\x00' looking for beginning of value
        >>)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 1, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 3, 2023

Duplicate of #59289

@bcmills bcmills marked this as a duplicate of #59289 Apr 3, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@golang golang locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot