Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/astutil: TestPurgeFuncBodies failures #59349

Closed
gopherbot opened this issue Mar 31, 2023 · 4 comments
Closed

x/tools/gopls/internal/astutil: TestPurgeFuncBodies failures #59349

gopherbot opened this issue Mar 31, 2023 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/astutil" && test == "TestPurgeFuncBodies"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestPurgeFuncBodies (0.31s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 31, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/astutil" && test == "TestPurgeFuncBodies"
2023-03-31 18:21 android-386-emu tools@902fdcad go@a7fd2fab x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.31s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 18:21 android-amd64-emu tools@902fdcad go@a7fd2fab x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.31s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 31, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/astutil" && test == "TestPurgeFuncBodies"
2023-03-31 18:21 android-386-emu tools@902fdcad go@63ef9059 x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.35s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 18:21 android-386-emu tools@902fdcad go@9a164d1c x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.28s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 18:21 android-amd64-emu tools@902fdcad go@63ef9059 x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.35s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 18:21 android-amd64-emu tools@902fdcad go@9a164d1c x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.28s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 19:13 android-386-emu tools@65208701 go@63ef9059 x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.32s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1
2023-03-31 19:13 android-amd64-emu tools@65208701 go@63ef9059 x/tools/gopls/internal/astutil.TestPurgeFuncBodies (log) 
--- FAIL: TestPurgeFuncBodies (0.29s)
    purge_test.go:26: err: exit status 2: stderr: go: no such tool "compile"

exitcode=1

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Mar 31, 2023 •
edited

CC @adonovan

Android builders don't have source code for std. We just need an additional skip. I'll fix.

@gopherbot
Copy link
Author

Change https://go.dev/cl/481275 mentions this issue: gopls/internal/astutil: TestPurgeFuncBodies requires source code for std

@golang golang locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr