Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: UI improvements for subrepo benchmarks #59337

Open
1 of 4 tasks
findleyr opened this issue Mar 30, 2023 · 2 comments
Open
1 of 4 tasks

x/build: UI improvements for subrepo benchmarks #59337

findleyr opened this issue Mar 30, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Mar 30, 2023

This issue tracks UI improvements following up on #53538. That issue reached a natural stopping point, as the benchmarks at perf.golang.org/dashboard are useful for the tools team but there is more lower priority UI work that could be done.

Specifically:

  • Links to commits are be broken (they go to the Go repo). Fix those.
  • We probably also want some UI distinction that these are x/tools benchmarks and thus the x axis and baseline is completely unrelated to other benchmarks.
  • Because runs will trigger on changes to the Go repo, we will end up with duplicate points at the same experiment commit date (overlapping on the x axis). We should visually deduplicate these somehow (perhaps only render the first one we find).
  • Most links drop query parameters, making it painful to navigate around when the tools repo is selected.

CC @prattmic

@findleyr findleyr added this to the gopls/later milestone Mar 30, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 30, 2023
@prattmic
Copy link
Member

Commit links are already correct, those were fixed a while ago.

I'd also add that links around the UI almost all drop the existing URL query parameters, which is quite painful for the tools results, as most links are broken, trying to go to some tools benchmark but in the go repo.

@findleyr
Copy link
Contributor Author

Commit links are already correct, those were fixed a while ago.

Right, thanks! Added your suggestion (and yes, that is a pain -- I've learned to only visit the shortlink I created).

Also: feel free to edit the issue to add whatever you want.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants