Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/subtle: xor fails when run with race+purego #59334

Closed
randall77 opened this issue Mar 30, 2023 · 3 comments
Closed

crypto/subtle: xor fails when run with race+purego #59334

randall77 opened this issue Mar 30, 2023 · 3 comments
Assignees
@randall77
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@randall77
Copy link
Contributor 

go test -tags=purego -race -bench=BenchmarkAESCFBEncrypt1K crypto/cipher

This fails with a checkptr fault.

Kinda a false positive, kinda not. checkptr is failing correctly, in that a pointer is generated that straddles two allocations. But that pointer is never used.

Split off from #58785
@randall77 randall77 self-assigned this Mar 30, 2023
@gopherbot
Copy link

Change https://go.dev/cl/480575 mentions this issue: crypto/subtle: don't cast to *uintptr when word size is 0

@randall77
Copy link
Contributor Author

@gopherbot please open a backport issue to 1.20. This is a potential crash when running with the race detector.

This code is quite different in 1.19. I don't think it suffers from the same issue.

This was referenced Mar 30, 2023
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #59335 (for 1.19), #59336 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 31, 2023
@bcmills bcmills added this to the Go1.21 milestone Mar 31, 2023
@greatroar greatroar mentioned this issue Apr 1, 2023
Closed
@golang golang locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@randall77 randall77

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@bcmills @randall77 @gopherbot