Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: 3.14% regression in AppendMsgResyncTargetsInfo-8 sec/op at 61bc17f #59319

Closed
mknyszek opened this issue Mar 29, 2023 · 2 comments
Closed

cmd/compile: 3.14% regression in AppendMsgResyncTargetsInfo-8 sec/op at 61bc17f #59319

mknyszek opened this issue Mar 29, 2023 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Performance
Milestone
Go1.21

Comments

@mknyszek
Copy link
Contributor

Discovered a regression in sec/op of 3.14% for benchmark AppendMsgResyncTargetsInfo-8 at 61bc17f.

CC @randall77

Note: This might not matter. This benchmark has a weird history.
@mknyszek mknyszek added this to the Go1.21 milestone Mar 29, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 29, 2023
@randall77
Copy link
Contributor

I don't see any differences in assembly for any of the of the functions that appear in a cpu profile of this benchmark.
Closing, probably just code alignment issues.

@mknyszek
Copy link
Contributor Author

mknyszek commented Mar 30, 2023 •
edited

I'm inclined to delete this benchmark, based on that.

@golang golang locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Performance
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@mknyszek @randall77 @gopherbot