Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: 1.19 is missing #59303

Closed
rittneje opened this issue Mar 29, 2023 · 5 comments
Closed

x/playground: 1.19 is missing #59303

rittneje opened this issue Mar 29, 2023 · 5 comments
Assignees
@findleyr
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@rittneje
Copy link

Currently the playground lists "Go 1.20", "Go 1.21", and "Go dev branch". 1.19 is missing, and 1.21 was not released yet.

image
@gopherbot gopherbot added this to the Unreleased milestone Mar 29, 2023
@dmitshur
Copy link
Contributor

Thanks for reporting.

It might be because CL 467955 (CC @petergeorgas) removed the -prev flag, which is still used, and https://goprevplay.golang.org/version ends up deploying tip rather than 1.19.7.

CC @findleyr.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 29, 2023
@findleyr findleyr self-assigned this Mar 29, 2023
@gopherbot
Copy link

Change https://go.dev/cl/480235 mentions this issue: cmd/latestgo: restore the -prev flag

@gopherbot
Copy link

Change https://go.dev/cl/480275 mentions this issue: deploy: fail the goprev deployment if latestgo fails

gopherbot pushed a commit to golang/playground that referenced this issue Mar 29, 2023
@findleyr
deploy: fail the goprev deployment if latestgo fails
27f5283 
In golang/go#59303, we observed (surprisingly) that the goprev
playground deployment proceeded with deploying using tip Go after the
latestgo command failed.

Fix the latestgo invocation to exit with a non-zero exit code when
latestgo fails.

For golang/go#59303

Change-Id: Ie07764b71ce42bddbff6266b0bb8684140d02af4
Reviewed-on: https://go-review.googlesource.com/c/playground/+/480275
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr
Copy link
Contributor

findleyr commented Mar 29, 2023 •
edited

Fix has been deployed. Thank you for reporting, and thank you @dmitshur for investigating.

@gopherbot
Copy link

Change https://go.dev/cl/555656 mentions this issue: deploy: prune old App Engine versions for 2 more playgrounds

gopherbot pushed a commit to golang/playground that referenced this issue Jan 16, 2024
@dmitshur @gopherbot
deploy: prune old App Engine versions for 2 more playgrounds
8d67851 
CL 398574 added a step to use versionprune and prune old versions of
the gotip playground. Apply the same change to the other two for the
same reason.

Also switch from 'go install' to 'go run' to simplify the invocation,
and use a single dash in flags as is canonical style for Go commands.

While here, also improve consistency between these files:

• apply the change in CL 480275 to deploy.json too
• use 'sh' everywhere, instead of a mix of 'bash' and 'sh'
• drop GO111MODULE=on since it's the default

For golang/go#59303.

Change-Id: I921e768d15743a7a93ece8a1f671eaa0ee2e328a
Reviewed-on: https://go-review.googlesource.com/c/playground/+/555656
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @rittneje @findleyr