Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows/svc: TestExample failures #59298

Closed
gopherbot opened this issue Mar 28, 2023 · 5 comments
Closed

x/sys/windows/svc: TestExample failures #59298

gopherbot opened this issue Mar 28, 2023 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/sys/windows/svc" && test == "TestExample"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestExample (0.77s)
    svc_test.go:108: CreateService(myservice) failed: The name is already in use as either a service name or a service display name.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 28, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/sys/windows/svc" && test == "TestExample"
2023-03-17 00:07 windows-amd64-longtest sys@00d8004a go@cd25a3a4 x/sys/windows/svc.TestExample (log) 
--- FAIL: TestExample (0.77s)
    svc_test.go:108: CreateService(myservice) failed: The name is already in use as either a service name or a service display name.

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Mar 28, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 31, 2023

(attn @golang/windows)

@bcmills
Copy link
Contributor

bcmills commented Mar 31, 2023

Also, the skip for this test is wrong: since it modifies system services, it should be skipped if GO_BUILDER_NAME is unset, not skipped if it is set:
https://cs.opensource.google/go/x/sys/+/master:windows/svc/svc_test.go;l=80;drc=0ec99a608a1b8e24d6a2554b64f4208e8e5caae7

@gopherbot
Copy link
Author

Change https://go.dev/cl/481015 mentions this issue: windows/svc: use separate (and more descriptive) service names in tests

@golang golang locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot and others