log/slog: drop only completely empty Attrs #59282
Comments
|
This proposal has been added to the active column of the proposals project |
|
I think this is a good idea. After the decision was made to interpret an empty key as a "skip" attr I was wondering if that would cause problems with the |
|
Based on the discussion above, this proposal seems like a likely accept. |
|
Change https://go.dev/cl/484095 mentions this issue: |
|
No change in consensus, so accepted. 🎉 |
rsc
changed the title
Specify that Handlers should ignore zero-valued Attrs. Implement that policy in the built-in handlers. Fixes golang#59282. Change-Id: I4430686b61f49bdac849ee300daaabfac9895849 Reviewed-on: https://go-review.googlesource.com/c/go/+/484095 Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
Specify that Handlers should ignore zero-valued Attrs. Implement that policy in the built-in handlers. Fixes golang#59282. Change-Id: I4430686b61f49bdac849ee300daaabfac9895849 Reviewed-on: https://go-review.googlesource.com/c/go/+/484095 Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
Currently, handlers are expected to drop attributes with an empty key (except for Groups), and the built-in handlers do so. I propose changing that convention: only an Attr whose key is empty and whose value is nil should be dropped.
@ianthehat pointed out to me that omitting the key but not the value could indicate a bug (for example, by using a variable for the key that unintentionally holds the empty string). One of slog's tenets is to display whatever it can—that's why we display mismatched key-value pairs instead of dropping them or failing—and the same argument applies here.
Most uses of this feature are probably in
ReplaceAttrfunctions, where it is easy to make this change.Handlers can detect an empty Attr
awitha.Equal(Attr{}).See also #56345.
The text was updated successfully, but these errors were encountered: