Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releaseschedule: dark mode aware svg #59275

Closed
crisman opened this issue Mar 27, 2023 · 2 comments
Closed

x/build/cmd/releaseschedule: dark mode aware svg #59275

crisman opened this issue Mar 27, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@crisman
Copy link
Contributor

crisman commented Mar 27, 2023

What version of Go are you using (go version)?

go version go1.20.2 linux/amd64

What did you do?

View the Go Release Cycle wiki page at https://go.dev/s/release

The release SVG after the second paragraph under Timeline looks fine in default mode:

image

but is mostly unreadable if the os/browser/github settings are set to dark mode:

image

What did you expect to see?

Would like to get the black text/lines in the SVG in white if in dark mode.

What did you see instead?

Black on dark as in second image above.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 27, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 27, 2023
crisman added a commit to crisman/golang_build that referenced this issue Mar 27, 2023
@crisman
cmd/releaseschedule: add dark mode aware svg css
8580eb7 
The SVG image used on https://go.dev/s/release is mostly unreadable if
viewed in dark mode (set in OS, browser, or github settings) as the black
text/lines on dark background are too close in color. It would be possible to
set a background color on the svg, but I think the better answer is CSS in
the SVG which is @media aware of prefers-color-scheme:dark to switch the
colors from black to white.

Remove the explicit style on line/path and add css for text/line/path which
is black but in dark mode changes to white.

Updates golang/go#58820
Fixes golang/go#59275
@crisman crisman mentioned this issue Mar 27, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/479575 mentions this issue: cmd/releaseschedule: add dark mode aware svg css

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 27, 2023
@heschi
Copy link
Contributor

heschi commented Mar 27, 2023

Regenerated the SVG.

@golang golang locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

cmd/releaseschedule: add dark mode aware svg css crisman/golang_build
4 participants
@crisman @dmitshur @gopherbot @heschi