Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: Add AEAD AES-CBC with HMAC-SHA2 #59241

Open
ItalyPaleAle opened this issue Mar 25, 2023 · 1 comment
Open

x/crypto: Add AEAD AES-CBC with HMAC-SHA2 #59241

ItalyPaleAle opened this issue Mar 25, 2023 · 1 comment
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone

Comments

@ItalyPaleAle
Copy link

AES-CBC with HMAC-SHA2 is an AEAD cipher based on AES-CBC with an additional MAC computed with HMAC-SHA2. It is defined in a draft RFC and included in RFC 7518 (JWA: JSON Web Algorithms). It is very popular in the JWx world, for example used to encrypt the content of JWE messages (including JWTs).

I would like to propose that an official implementation for this cipher be considered for the x/crypto package.

We recently had to implement this for Dapr. We initially hoped to find 3rd-party implementations, but all the ones we could find were either too intertwined with larger JWx libraries, or contained a number of issues (for example with incorrectly implement the cipher.AEAD interface or incorrectly supporting appending output to an existing byte slice).

@gopherbot gopherbot added this to the Unreleased milestone Mar 25, 2023
@seankhliao seankhliao added the Proposal-Crypto Proposal related to crypto packages or other security issues label Mar 26, 2023
@seankhliao
Copy link
Member

cc @golang/security

@ianlancetaylor ianlancetaylor modified the milestones: Unreleased, Proposal Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Status: Incoming
Development

No branches or pull requests

4 participants