Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/gitfs: TestGitHub failures #59222

Open
gopherbot opened this issue Mar 24, 2023 · 3 comments
Open

x/website/internal/gitfs: TestGitHub failures #59222

gopherbot opened this issue Mar 24, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/website/internal/gitfs" && test == "TestGitHub"

Issue created automatically to collect these failures.

Example (log):

Counting objects: 1   
Counting objects: 480, done

Finding sources:   1% (3/480)   
Finding sources:   2% (8/480)   
Finding sources:   3% (12/480)   
Finding sources:   4% (17/480)   
Finding sources:   5% (22/480)   
Finding sources:   6% (27/480)   
Finding sources:   7% (32/480)   
...
--- FAIL: TestGitHub (30.03s)
    git_test.go:38: handshake: Get "https://github.com/rsc/quote/info/refs?service=git-upload-pack": dial tcp 140.82.112.4:443: i/o timeout
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import "fmt"

func greeting() {
	println(1)
	fmt.Println("hello, git32 ")
}

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/website/internal/gitfs" && test == "TestGitHub"
2023-03-20 20:35 linux-386-longtest website@710879a4 go@e4abe90b x/website/internal/gitfs.TestGitHub (log)
Counting objects: 1   
Counting objects: 480, done

Finding sources:   1% (3/480)   
Finding sources:   2% (8/480)   
Finding sources:   3% (12/480)   
Finding sources:   4% (17/480)   
Finding sources:   5% (22/480)   
Finding sources:   6% (27/480)   
Finding sources:   7% (32/480)   
...
--- FAIL: TestGitHub (30.03s)
    git_test.go:38: handshake: Get "https://github.com/rsc/quote/info/refs?service=git-upload-pack": dial tcp 140.82.112.4:443: i/o timeout
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import "fmt"

func greeting() {
	println(1)
	fmt.Println("hello, git32 ")
}

watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Mar 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/website/internal/gitfs" && test == "TestGitHub"
2023-03-24 18:05 windows-amd64-longtest website@2f994f81 go@3ed8a1e6 x/website/internal/gitfs.TestGitHub (log)
Counting objects: 1   
Counting objects: 480, done

Finding sources:   1% (3/480)   
Finding sources:   2% (8/480)   
Finding sources:   3% (12/480)   
Finding sources:   4% (17/480)   
Finding sources:   5% (22/480)   
Finding sources:   6% (27/480)   
Finding sources:   7% (32/480)   
...
--- FAIL: TestGitHub (10.04s)
    git_test.go:38: handshake: Get "https://github.com/rsc/quote/info/refs?service=git-upload-pack": net/http: TLS handshake timeout
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import "fmt"

func greeting() {
	println(1)
	fmt.Println("hello, git32 ")
}

watchflakes

@bcmills bcmills added the website label Apr 3, 2023
@findleyr
Copy link
Contributor

findleyr commented Apr 6, 2023

I'm not sure what to do with this issue: the test already runs only on longtest builders, and requires access to github.
Test flakes due to I/O or upstream connectivity issues seem to be WAI.

I guess I'll leave this bug open to catch the flakes. Unless there is an apparent builder or configuration issue (which I don't see here), this bug is unactionable.

@findleyr findleyr modified the milestones: Unreleased, website/unplanned Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
Status: No status
Development

No branches or pull requests

3 participants