Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: crash on linux-ppc64le [1.20 backport] #59220

Closed
gopherbot opened this issue Mar 24, 2023 · 4 comments
Closed

runtime: crash on linux-ppc64le [1.20 backport] #59220

gopherbot opened this issue Mar 24, 2023 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.3

Comments

@gopherbot
Copy link
Contributor

@laboger requested issue #59196 to be considered for backport to the next 1.20 minor release.

@gopherbot please open the backport tracking issues for Go 1.20 and 1.19. This is an assembler regression that results in a serious error and has no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 24, 2023
@gopherbot gopherbot mentioned this issue Mar 24, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 24, 2023
@gopherbot gopherbot added this to the Go1.20.3 milestone Mar 24, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/479475 mentions this issue: cmd/internal/obj/ppc64: fix incorrect base reg causing segv

@gopherbot

This comment was marked as resolved.

Sign in to view
@laboger
Copy link
Contributor

laboger commented Mar 27, 2023

This is a serious issue in the assembler in which generates an instruction that uses r0 as the base register. The result is a segv if that instruction is executed. There is no workaround. Refer to the original issue for further detail.
(The second CL listed here has been abandoned. It was incorrectly created when I tried to resolve merge problems with the first cherry-pick.)

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Mar 29, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 29, 2023
gopherbot pushed a commit that referenced this issue Mar 29, 2023
@laboger @mdempsky
[release-branch.go1.20] cmd/internal/obj/ppc64: fix incorrect base re…
9a164d1 
…g causing segv

This fixes a segv that was reported due to building minio. The
problem occurred because of an incorrect selection of the
base register, which was introduced by CL 306369.

Fixes #59220

Change-Id: Ieb77b2afa8fb4e6f3943df5ce138679f6750d376
Reviewed-on: https://go-review.googlesource.com/c/go/+/479475
Reviewed-by: Archana Ravindar <aravind5@in.ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 9a164d1 to release-branch.go1.20.

@sumitd2 sumitd2 mentioned this issue Mar 30, 2023
Closed
@golang golang locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.3
Development

No branches or pull requests
3 participants
@gopherbot @laboger @heschi