Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: crash on linux-ppc64le [1.19 backport] #59219

Closed
gopherbot opened this issue Mar 24, 2023 · 7 comments
Closed

runtime: crash on linux-ppc64le [1.19 backport] #59219

gopherbot opened this issue Mar 24, 2023 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.8

Comments

@gopherbot
Copy link

@laboger requested issue #59196 to be considered for backport to the next 1.19 minor release.

@gopherbot please open the backport tracking issues for Go 1.20 and 1.19. This is an assembler regression that results in a serious error and has no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 24, 2023
@gopherbot gopherbot mentioned this issue Mar 24, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 24, 2023
@gopherbot gopherbot added this to the Go1.19.8 milestone Mar 24, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/479628 mentions this issue: [release-branch.go1.19] cmd/internal/obj/ppc64: fix incorrect base reg causing segv

@laboger
Copy link
Contributor

laboger commented Mar 27, 2023

This is a serious issue in the assembler in which generates an instruction that uses r0 as the base register. The result is a segv if that instruction is executed. There is no workaround. Refer to the original issue for further detail.

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Mar 29, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 29, 2023
@laboger
Copy link
Contributor

laboger commented Mar 29, 2023

@heschi The author @sumitd2 of the original issue is asking for it in Go 1.19. How soon will the next 1.19 release be available?

@heschi
Copy link
Contributor

heschi commented Mar 29, 2023

We've already locked in the content for next week's release, so I expect this will land in the May minor releases, which should probably be on the 2nd.

gopherbot pushed a commit that referenced this issue Mar 29, 2023
@laboger @mdempsky
[release-branch.go1.19] cmd/internal/obj/ppc64: fix incorrect base re…
6d9df0a 
…g causing segv

This fixes a segv that was reported due to building minio. The
problem occurred because of an incorrect selection of the
base register, which was introduced by CL 306369.

Fixes #59219

Change-Id: Ieb77b2afa8fb4e6f3943df5ce138679f6750d376
Reviewed-on: https://go-review.googlesource.com/c/go/+/479628
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Author

Closed by merging 6d9df0a to release-branch.go1.19.

@sumitd2
Copy link

sumitd2 commented Mar 30, 2023

We've already locked in the content for next week's release, so I expect this will land in the May minor releases, which should probably be on the 2nd.

@heschi When is the next point release of the 1.20 backport (#59220) of the same issue going to be available? And what about 1.21? @laboger @sethp

@heschi
Copy link
Contributor

heschi commented Mar 30, 2023

We ended up doing another round of cherrypicks so it'll go out for 1.19 and 1.20 next week. Not sure what you're asking about 1.21, since that's not out for months.

@golang golang locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.8
Development

No branches or pull requests
4 participants
@gopherbot @laboger @heschi @sumitd2