Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: package removal request for github.com/google/flatbuffers/go #59214

Closed
le-michael opened this issue Mar 24, 2023 · 2 comments
Closed

x/pkgsite: package removal request for github.com/google/flatbuffers/go #59214

le-michael opened this issue Mar 24, 2023 · 2 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
Unreleased

Comments

@le-michael
Copy link

What is the path of the package that you would like to have removed?

https://pkg.go.dev/github.com/google/flatbuffers/go

Are you the owner of this package?

I am a maintainer of the package.

CC @dbaileychess who is the owner.

What is the reason that you could not retract this package instead?

https://github.com/google/flatbuffers is a monorepo and does not have a valid go.mod file so we are unable to retract the faulty version.

v23.1.4+incompatible introduced a go.mod file that broke build for multiple clients and created the faulty package on pkg.go.dev. In the versions after we removed the faulty go.mod so https://pkg.go.dev/github.com/google/flatbuffers/go does not point to a valid version.

If possible could we remove the faulty version v23.1.4+incompatible as well?

google/flatbuffers#7873
@le-michael le-michael added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Mar 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 24, 2023
@le-michael
Copy link
Author

Note the correct package is https://pkg.go.dev/github.com/google/flatbuffers which we don't want to be affected by this removal.

@jamalc
Copy link

jamalc commented Mar 24, 2023

You must retract the versions you wish to remove. Removing the module at github.com/google/flatbuffers/go will also hide the package github.com/google/flatbuffers/go. The module version you publish to retract github.com/google/flatbuffers/go should also retract itself.

@jamalc jamalc closed this as completed Mar 24, 2023
@golang golang locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @le-michael @jamalc