Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: internal error: non-deterministic parsing result #59097

Closed
findleyr opened this issue Mar 17, 2023 · 3 comments
Closed

x/tools/gopls: internal error: non-deterministic parsing result #59097

findleyr opened this issue Mar 17, 2023 · 3 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

In https://go.dev/cl/473165, I adjusted the parse cache logic for reparsing syntax that had to be fixed.

This logic includes an assumption that parsing is deterministic (which one would hope is true!). However, that assumption is clearly violated, or I have a bug in my implementation of that assumption, as I've hit the included panic twice already.

CC @adonovan
@findleyr findleyr added this to the gopls/v0.12.0 milestone Mar 17, 2023
@findleyr findleyr self-assigned this Mar 17, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/477315 mentions this issue: gopls/internal/lsp/cache: record additional info during parse fixing

@adonovan
Copy link
Member

I've hit the included panic twice already.

Which panic? (Did you mean to include it in this issue?)

@findleyr
Copy link
Contributor Author

Oh, it's in the title, but I should have linked.

This one:
https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/cache/parse_cache.go;l=181;drc=b222520ff002290a694dda6a6dfe858cf8d8dfe6

@golang golang locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr