Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: panic in quickParse #59096

Closed
findleyr opened this issue Mar 17, 2023 · 1 comment
Closed

x/tools/gopls: panic in quickParse #59096

findleyr opened this issue Mar 17, 2023 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

The new quickParse function added in https://go.dev/cl/472183 assumes that the ast.SelectorExpr.Sel is non-nil, which is true for all valid AST but unfortunately not true for the synthetic AST produced during completion.

I have a fix incoming; adding this issue for record keeping.

CC @adonovan
@findleyr findleyr added the gopls/completion Issues related to auto-completion in gopls. label Mar 17, 2023
@findleyr findleyr added this to the gopls/v0.12.0 milestone Mar 17, 2023
@findleyr findleyr self-assigned this Mar 17, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/477255 mentions this issue: gopls/internal/lsp/source: fix panic in quickParse

@golang golang locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr