Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: top-left link not working #59094

Closed
Deleplace opened this issue Mar 17, 2023 · 5 comments
Closed

x/website/tour: top-left link not working #59094

Deleplace opened this issue Mar 17, 2023 · 5 comments
Assignees
@jamalc
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
website/backlog

Comments

@Deleplace
Copy link
Contributor

What did you do?

image

What did you expect to see?

https://go.dev/

What did you see instead?

Stays on current page https://go.dev/tour/welcome/1
@gopherbot gopherbot added this to the Unreleased milestone Mar 17, 2023
@Deleplace
Copy link
Contributor Author

Observed in Chrome and in Firefox

@cherrymui
Copy link
Member

It seems that link always goes back to the first page of the tour https://go.dev/tour/welcome/1 , even if the current package is at a later part of the tour (e.g. on https://go.dev/tour/basics/5).

cc @golang/tools-team

@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website labels Mar 17, 2023
@Deleplace
Copy link
Contributor Author

Deleplace commented Mar 20, 2023 •
edited

I think clicks are processed by an Angular controller, and "unexpected" internal links are redirected to /tour/, which then redirects to /tour/welcome/1

        otherwise({
            redirectTo: '/tour/'
        });

@Deleplace
Copy link
Contributor Author

This is a client-side problem. The server is not hit at all during navigation.

@jamalc jamalc self-assigned this Mar 24, 2023
@jamalc jamalc modified the milestones: Unreleased, website/later Mar 24, 2023
@gopherbot
Copy link

Change https://go.dev/cl/481675 mentions this issue: _content/tour: fix top-left link to homepage

@golang golang locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
4 participants
@gopherbot @Deleplace @cherrymui @jamalc