Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: Dark mode #59093

Closed
Deleplace opened this issue Mar 17, 2023 · 6 comments
Closed

x/website/tour: Dark mode #59093

Deleplace opened this issue Mar 17, 2023 · 6 comments
Labels
FrozenDueToAge website
Milestone
website/backlog

Comments

@Deleplace
Copy link
Contributor

The current UI of https://go.dev/tour only has a light theme

image

An additional dark theme would be very nice to have, like already implemented in the other parts of https://go.dev/
@gopherbot gopherbot added this to the Unreleased milestone Mar 17, 2023
@Deleplace
Copy link
Contributor Author

I may help with the implementation, while also taking other accessibility concerns into consideration.
@alicemerrick @jamalc @fflewddur

@lucasres
Copy link

That would be really cool. If you need help, I'm also willing to help.

@cherrymui
Copy link
Member

cc @golang/tools-team

@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website labels Mar 17, 2023
@Deleplace
Copy link
Contributor Author

TIL this has been asked ~10 times in the golang/tour issue tracker (using the "Share feedback" button, top-right in the Tour)

@jamalc jamalc modified the milestones: Unreleased, website/later Mar 24, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/509116 mentions this issue: website/tour: dark theme UI similar to the already implemented in https://go.dev/

@hyangah hyangah removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 11, 2023
@hyangah
Copy link
Contributor

hyangah commented Sep 11, 2023

Fix verified. Thanks!

@hyangah hyangah closed this as completed Sep 11, 2023
@golang golang locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
6 participants
@hyangah @gopherbot @Deleplace @cherrymui @jamalc @lucasres