-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls/internal/regtest/workspace: unrecognized failures #59080
Comments
Found new dashboard test flakes for:
2023-03-16 18:45 linux-ppc64le-buildlet tools@b222520f go@23e8f43c x/tools/gopls/internal/regtest/workspace (log)
|
This one is concerning. Almost certainly related to the new parsing/caching logic, but I don't know how yet. CC @adonovan |
Change https://go.dev/cl/477275 mentions this issue: |
I think I see the bug, in AddExistingFiles:
The line marked 'here' should be comparing against out[len(out)-1], the last item to come out the filter, not the last to go in. I've lost count of how many times I've made this mistake. |
To narrow down the concerning issue golang/go#59080, add additional early debug assertions to help narrow down a root cause. For golang/go#59080 Change-Id: Ib18c2e7328eaf059c908afc6260f3212f685573c Reviewed-on: https://go-review.googlesource.com/c/tools/+/477275 Reviewed-by: Alan Donovan <adonovan@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Hmm, I thought about that during review. Since we've already sorted by base, the only way this could matter is if we have multiple files with the same base. That would be a bug. |
Still waiting to see a second instance of this panic, or the first instance of failure of the new assertions added in CL https://go.dev/cl/477275. |
No reoccurences since the first failure. We've seen spurious NPE on ppc64 (e.g. #59910), so I think this is not worth pursuing unless we get a reoccurence. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: