Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: TestCondSignalStealing failures #59043

Closed
gopherbot opened this issue Mar 15, 2023 · 5 comments
Closed

sync: TestCondSignalStealing failures #59043

gopherbot opened this issue Mar 15, 2023 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "sync" && test == "TestCondSignalStealing"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCondSignalStealing (2.90s)
    cond_test.go:234: First waiter didn't get broadcast.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 15, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "sync" && test == "TestCondSignalStealing"
2023-03-14 13:17 freebsd-arm-paulzhol go@035db07d sync.TestCondSignalStealing (log) 
--- FAIL: TestCondSignalStealing (2.90s)
    cond_test.go:234: First waiter didn't get broadcast.

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 15, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 15, 2023

This is another arbitrary timeout that can fail due to a scheduling delay:
https://cs.opensource.google/go/go/+/master:src/sync/cond_test.go;l=230-235;drc=dc12d5b0f5e9c1cfec2a8eb6dd7ff3473c36d45c

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Mar 15, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 15, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 15, 2023

Seems easy enough to just change the select to an unconditional channel-receive.

@collinwright collinwright mentioned this issue Mar 20, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/477955 mentions this issue: sync: fix TestCondSignalStealing flake

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "sync" && test == "TestCondSignalStealing"
2023-03-22 11:15 openbsd-arm64-jsing go@bd20bf48 sync.TestCondSignalStealing (log) 
--- FAIL: TestCondSignalStealing (0.00s)
    cond_test.go:234: First waiter didn't get broadcast.

— watchflakes

@golang golang locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync: fix TestCondSignalStealing flake collinwright/go
2 participants
@bcmills @gopherbot