Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: test failures with EBADF #59032

Closed
bcmills opened this issue Mar 14, 2023 · 1 comment
Closed

x/tools/gopls: test failures with EBADF #59032

bcmills opened this issue Mar 14, 2023 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 14, 2023 

#!watchflakes
post <- pkg ~ `^golang\.org/x/tools/gopls` && log ~ `bad file number`

Example failure (https://build.golang.org/log/347349f3689f6799b4e857ec5e9d93ca7a34e2e9):

--- FAIL: TestReferences (10.31s)
    integration_test.go:490: gopls references a.go:4:10: exited with code 2, want success: true (gopls references a.go:4:10: exit=2 stdout=<<>> stderr=<<gopls: RLock /opt/golang/.cache/gopls/0d935b09/export/5c/5c19d490bd139935740bf392e86bbde5fc4f527c4689a1481a4fc93b522e0516: bad file number
        >>)
    integration_test.go:491: gopls references a.go:4:10: stdout does not match [a.go:4:6-13]; got <<>>
    integration_test.go:492: gopls references a.go:4:10: stdout does not match [b.go:4:6-13]; got <<>>
FAIL
FAIL	golang.org/x/tools/gopls/internal/lsp/cmd/test	33.029s

I suspect that this occurs when we call RLock on a file that has already been closed.

(CC @findleyr @adonovan)
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 14, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 14, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Mar 14, 2023

Duplicate of #58904

@bcmills bcmills marked this as a duplicate of #58904 Mar 14, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
@golang golang locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot