Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: make the darwin/amd64 installer warn the user or fail when running on arm64 #59010

Open
cespare opened this issue Mar 13, 2023 · 2 comments
Open

x/build: make the darwin/amd64 installer warn the user or fail when running on arm64 #59010

cespare opened this issue Mar 13, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@cespare
Copy link
Contributor

cespare commented Mar 13, 2023

The download website makes it easy for all macOS users, even the ones running on Apple Silicon, to download the amd64 package. This is #52487.

As described in #52487 (comment), this mostly works, and users can go on quite a while not realizing that they're running the Go toolchain under emulation (and producing amd64 binaries which are also running under emulation). The problems that eventually arise can be very subtle.

Besides fixing the website download links, we should consider making the amd64 installer refuse to run on arm64 chips or at least warn the user that they are not installing the correct package for their architecture.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 13, 2023
@cespare cespare mentioned this issue Mar 13, 2023
Open
@cespare
Copy link
Contributor Author

cespare commented Mar 13, 2023

This is tangentially related to #58235.

Also cc @golang/release and @dmitshur.

@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 13, 2023
@hyangah
Copy link
Contributor

hyangah commented Mar 13, 2023

Another idea is whether the installer carries only a bootstrap part (either universal, or a binary running on rosetta, or a bash script) and during install, it downloads the right versions.
For extended forward compatibility support (#57001) I think there will be compact versions of core toolings and standard libraries. I wonder if they can be utilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cespare @hyangah @gopherbot @cherrymui