Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: missing error for dot-imported name conflicts #59005

Closed
findleyr opened this issue Mar 13, 2023 · 1 comment
Closed

x/tools/gopls: missing error for dot-imported name conflicts #59005

findleyr opened this issue Mar 13, 2023 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Contributor

The following program doesn't produce a type error in gopls, even though it does from the compiler and (it appears) from the type-checker.

https://go.dev/play/p/6vbojz0jhVE

package main

import (
	"fmt"

	. "play.ground/foo"
)

const C = 1

func main() {
	fmt.Println(C)
}
-- go.mod --
module play.ground
-- foo/foo.go --
package foo

const C = 2

Why are we dropping this error, I wonder...
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/475919 mentions this issue: gopls/internal/lsp/cache: don't ignore type-errors that can't be mapped

@golang golang locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr