Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestQuerySemicolon failures #59004

Closed
gopherbot opened this issue Mar 13, 2023 · 4 comments
Closed

net/http: TestQuerySemicolon failures #59004

gopherbot opened this issue Mar 13, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Mar 13, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon" && date < "2023-08-01"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h1 (0.13s)
        --- FAIL: TestQuerySemicolon/h1/?a=1;x=bad&x=good/allow=false (0.01s)
            serve_test.go:6585: expected error mentioning semicolons from ParseForm, got <nil>

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 13, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon"
2023-03-13 14:20 dragonfly-amd64-622 go@b6f29d23 net/http.TestQuerySemicolon (log) 
--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h1 (0.13s)
        --- FAIL: TestQuerySemicolon/h1/?a=1;x=bad&x=good/allow=false (0.01s)
            serve_test.go:6585: expected error mentioning semicolons from ParseForm, got <nil>

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Mar 13, 2023

(attn @neild)

I think the failure in TestQuerySemilcolon is actually a symptom of #56421. The second request in TestServerShutdown goes to a server that has already been shut down, but nothing prevents that request from going to some other server that is subsequently opened on the same port. Probably in this case that “some other server” is the one opened for TestQuerySemicolon.

@bcmills
Copy link
Contributor

bcmills commented Mar 13, 2023

Duplicate of #56421

@bcmills bcmills marked this as a duplicate of #56421 Mar 13, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2023
@gopherbot gopherbot reopened this Aug 23, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestQuerySemicolon"
2023-08-22 20:48 linux-s390x-ibm-race go@a65b4904 net/http.TestQuerySemicolon (log) 
--- FAIL: TestQuerySemicolon (0.00s)
    --- FAIL: TestQuerySemicolon/h2 (3.14s)
        --- FAIL: TestQuerySemicolon/h2/?a=1%3Bx=bad&x=good%3B/allow=true (2.50s)
            serve_test.go:6583: Get "https://127.0.0.1:35513?a=1%3Bx=bad&x=good%3B": read tcp 127.0.0.1:51280->127.0.0.1:35513: read: connection reset by peer

— watchflakes

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot