Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/gerrit: Unable to SetReview robot_comments, missing API #58983

Closed
kallisti5 opened this issue Mar 11, 2023 · 1 comment
Closed

x/build/gerrit: Unable to SetReview robot_comments, missing API #58983

kallisti5 opened this issue Mar 11, 2023 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@kallisti5
Copy link

Gerrit offers a "robot_comments" API:
https://gerrit-review.googlesource.com/Documentation/config-robot-comments.html

This doesn't seem to be available in https://pkg.go.dev/golang.org/x/build/gerrit#Client.SetReview however.

As a large usage of the gerrit go module will be automation, it seems odd the REST API for robot_comments isn't available.
@seankhliao seankhliao changed the title build/gerrit: Unable to SetReview robot_comments, missing API x/build/gerrit: Unable to SetReview robot_comments, missing API Mar 12, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 12, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2023
@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels Mar 12, 2023
@dmitshur
Copy link
Contributor

Thanks for reporting this. The package comment is now more clear that this package is for the internal needs of the Go project infrastructure, so it's working as intended that it covers a small subset. There are better suited general-purpose Gerrit API clients, e.g., see the top result at https://pkg.go.dev/search?q=gerrit. Closing since we'll get to this only if a need for it comes up, and there's not much use in tracking it until then.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@kallisti5 @dmitshur @gopherbot @seankhliao