Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: integration coverage blog post format issue #58981

Closed
crisman opened this issue Mar 11, 2023 · 2 comments
Closed

x/website: integration coverage blog post format issue #58981

crisman opened this issue Mar 11, 2023 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@crisman
Copy link
Contributor

crisman commented Mar 11, 2023

What did you do?

View the new blog post at
https://go.dev/blog/integration-test-coverage

What did you expect to see?

A two line code block listing for "these two additional lines".

What did you see instead?

<p>./mdtool.exe +ty testdata/README.md  &gt; /dev/null
./mdtool.exe +ta &lt; testdata/README.md  &gt; /dev/null</p>

which renders as one line without a code block on the web page.
@gopherbot gopherbot added this to the Unreleased milestone Mar 11, 2023
crisman added a commit to crisman/golang_website that referenced this issue Mar 11, 2023
@crisman
_content/blog: format typo in integration coverage
713f461 
In https://go-review.googlesource.com/c/website/+/474115 patchset 8
there was a change from a markdown fenced code block to a templated raw
block but skipped indenting it to make an indented code block. The
current blog has "these two additional lines" show up as one line with a
space between them. Given context and earlier patchsets it should
clearly still be a code block.

Indent the "two additional lines" to make them a markdown indented code
block inside the templated raw. This is the same formatting used in
"when-generics.md" and another score of blog pages.

Fixes golang/go#58981
@crisman
Copy link
Contributor Author

crisman commented Mar 11, 2023

Well, that's what I get for not looking first. Seems to be a fix already in Gerrit:
https://go-review.googlesource.com/c/website/+/474876

@seankhliao seankhliao added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Mar 11, 2023
@cagedmantis
Copy link
Contributor

Thanks for the report. It's been fixed in the CL you mentioned.

@golang golang locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cagedmantis @crisman @gopherbot @seankhliao