-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: crypto/elliptic build error under -linkshared mode #58966
Comments
It looks like the crypto/elliptic is now no more than a compatibility wrapper and the new crypto/ecdh don't implement the P-224 curves [2]. [2] https://words.filippo.io/dispatches/go-1-20-cryptography @FiloSottile is the author of the blog post so he maybe know better what going on. |
cc @rolandshoemaker @golang/security |
Standalone repro:
I think this is a compiler or linker issue, not an issue with crypto/elliptic itself. I expect the issue has to do with instantiating generic types across DSO boundaries (due to inlining). /cc @golang/compiler |
@cherrymui gave this explanation:
|
FYI, this is started failing since https://go-review.googlesource.com/c/go/+/443535 (with 18baca6 and de6abd7 applied for fixing |
The described steps to reproduce this issue uses |
Change https://go.dev/cl/476735 mentions this issue: |
@mdempsky maybe when building with |
Change https://go.dev/cl/477375 mentions this issue: |
Correct an error message to missing section, not unreachable symbol. Also, under -v >= 2, dump symbol info on error for debugging. Updates #58966. Change-Id: I0f832c517d64f4b672b313a8b9be2d028744f945 Reviewed-on: https://go-review.googlesource.com/c/go/+/476735 Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 (From OE-Core rev: afb3fc1701988dfcd79191343b49f4db0966236a) Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 (From OE-Core rev: d6a010a9d62fc1ae75935c0d0664b8353eede756) Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 (From OE-Core rev: d6a010a9d62fc1ae75935c0d0664b8353eede756) Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 (From OE-Core rev: eb40d6c2ef72814336365208722e2dc96322e07d) Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Since go 1.20 some packages fails to link [1][2] and only build staticaly with GO_LINKSHARED = "" [1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310 [2] golang/go#58966 Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
@gopherbot please backport this issue to go1.20 |
Backport issue(s) opened: #59236 (for 1.20). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
This reverts commit d2a630c. The linkshared is fixed upstream [1] and backported in oe-core [2] [1] golang/go#58966 [2] https://git.yoctoproject.org/poky/commit/?id=d5c79ca6a77af1a04992fff4300333e02d94d84d Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
The linkshared is fixed upstream [1] and backported in oe-core [2] [1] golang/go#58966 [2] https://git.yoctoproject.org/poky/commit/?id=d5c79ca6a77af1a04992fff4300333e02d94d84d Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?This issue can be reproduced inside the official
golang:1.20-alpine
docker container and it works fine on the previousgolang:1.19-alpine
go env
OutputWhat did you do?
This error has been discovered in Yocto/OpenEmbedded that builds the go shared std library and this issue also affect
other go projects [1], the workaround to build successfully since go 1.20 is not using the
-linkshared
[1] https://lists.yoctoproject.org/g/meta-virtualization/topic/97182310
Steps to reproduce:
What did you expect to see?
Build my go
linkshared
application without any errors like on previous version 1.19.What did you see instead?
Linking errors
The text was updated successfully, but these errors were encountered: