Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/ipv4: TestRawConnReadWriteUnicastICMP failures with i/o timeout #58955

Open
gopherbot opened this issue Mar 9, 2023 · 3 comments
Open

x/net/ipv4: TestRawConnReadWriteUnicastICMP failures with i/o timeout #58955

gopherbot opened this issue Mar 9, 2023 · 3 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Mar 9, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/net/ipv4" && test == "TestRawConnReadWriteUnicastICMP" && `i/o timeout`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRawConnReadWriteUnicastICMP (0.11s)
    unicast_test.go:249: read ip 0.0.0.0: raw-read ip4 0.0.0.0: i/o timeout

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 9, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/ipv4" && test == "TestRawConnReadWriteUnicastICMP"
2023-03-09 22:21 netbsd-arm-bsiegert net@9f24bb44 go@4df95d51 x/net/ipv4.TestRawConnReadWriteUnicastICMP (log) 
--- FAIL: TestRawConnReadWriteUnicastICMP (0.11s)
    unicast_test.go:249: read ip 0.0.0.0: raw-read ip4 0.0.0.0: i/o timeout

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Mar 9, 2023
@bcmills bcmills changed the title x/net/ipv4: TestRawConnReadWriteUnicastICMP failures x/net/ipv4: TestRawConnReadWriteUnicastICMP failures with i/o timeout Mar 10, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 10, 2023 •
edited

Arbitrary timeouts were added to that test (and many others) in https://go.dev/cl/21360043; it isn't at all clear to me why they were added, since the test fails if the timeout expires anyway.

Probably the deadlines just need to be removed (from all of those tests).

(https://cs.opensource.google/go/x/net/+/master:ipv4/unicast_test.go;l=237-247;drc=c7608f3a8462fd23f95e21be49b40c7b9c20c74a)

(CC @ianlancetaylor)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 10, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 10, 2023
nickfiggins added a commit to nickfiggins/net that referenced this issue May 5, 2023
@nickfiggins
ipv4/ipv6: remove unneeded deadlines added for flaky tests
eabd1d5 
Deadlines were added in https://go.dev/cl/21360043, but these are unneeded as the tests will fail anyways as a result of the timeout. This prevents these timeouts from causing further test flakes.

Fixes golang/go#58955
@nickfiggins nickfiggins mentioned this issue May 5, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/492620 mentions this issue: ipv4,ipv6: remove unneeded deadlines added for flaky tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: No status
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot