Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: SIGSEGV in misc/cgo/testsanitizers.TestTSAN/tsan13 on ppc64le #58953

Closed
bcmills opened this issue Mar 9, 2023 · 6 comments
Closed

runtime/cgo: SIGSEGV in misc/cgo/testsanitizers.TestTSAN/tsan13 on ppc64le #58953

bcmills opened this issue Mar 9, 2023 · 6 comments
Assignees
@laboger
Labels
arch-ppc64x compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.21

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 9, 2023

The new test added in CL 474198 is consistently failing on all of the linux/ppc64le builders (https://build.golang.org/log/af10e8db5c499065fa2b1afdb1f84c1a5e479ca1):

##### ../misc/cgo/testsanitizers
--- FAIL: TestTSAN (15.46s)
    --- FAIL: TestTSAN/tsan13 (3.86s)
        tsan_test.go:70: /workdir/tmp/TestTSAN4122310196/tsan13 exited with signal: segmentation fault (core dumped)
FAIL

The actual runtime/cgo change in that CL is very small and seems obviously correct, so I suspect that the test has uncovered a latent bug on this platform.

(attn @golang/ppc64; CC @golang/runtime @ianlancetaylor)
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-ppc64x compiler/runtime Issues related to the Go compiler and/or runtime. labels Mar 9, 2023
@bcmills bcmills added this to the Go1.21 milestone Mar 9, 2023
@laboger
Copy link
Contributor

laboger commented Mar 10, 2023

I'm looking at it.

@gopherbot
Copy link

Change https://go.dev/cl/475935 mentions this issue: runtime,runtime/cgo: fix tsan/pprof/cgo issues

@gopherbot
Copy link

Change https://go.dev/cl/475935 mentions this issue: runtime,runtime/cgo: fix ppc64le/linux tsan/pprof/cgo issues

@gopherbot
Copy link

Change https://go.dev/cl/476296 mentions this issue: runtime: add arg storage to ppc64le/linux runtime.sigprofNonGoWrapper frame

gopherbot pushed a commit that referenced this issue Mar 15, 2023
@pmur
runtime: add arg storage to ppc64le/linux runtime.sigprofNonGoWrapper…
a8cd10f 
… frame

CL 475935 fixed the the ELFv2 ABI violations, but in the process created a
Go ABI violation by failing to allocate stack space for arguments.

Allocate this space while keeping the frame 16 byte aligned.

Updates #58953

Change-Id: I9942d9a433118b391ef8cd7bcea5808695cf94d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/476296
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Archana Ravindar <aravind5@in.ibm.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@mknyszek
Copy link
Contributor

@laboger should this be closed? Thanks.

@pmur
Copy link
Contributor

pmur commented Mar 15, 2023

Yes. I munged the commit message which should have close it.

@pmur pmur closed this as completed Mar 15, 2023
@golang golang locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@laboger laboger

Labels
arch-ppc64x compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
5 participants
@mknyszek @bcmills @gopherbot @laboger @pmur