Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/testpty: fails on some Linux machines due to incorrect error handling #58940

Closed
heschi opened this issue Mar 8, 2023 · 2 comments
Closed

internal/testpty: fails on some Linux machines due to incorrect error handling #58940

heschi opened this issue Mar 8, 2023 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@heschi
Copy link
Contributor

heschi commented Mar 8, 2023 •
edited

Some tests that use PTYs failed in our new CI environment due to incorrect error handling, which I fixed in http://go.dev/cl/463397.
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 8, 2023
@heschi heschi added this to the Go1.21 milestone Mar 8, 2023
@heschi heschi closed this as completed Mar 8, 2023
@heschi
Copy link
Contributor Author

heschi commented Mar 8, 2023

@gopherbot please backport, the tests are failing on release branches too.

This was referenced Mar 8, 2023
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #58941 (for 1.19), #58942 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@golang golang locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@gopherbot @heschi