Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: source files links for stdlibs are incorrect in local mode #58923

Open
hyangah opened this issue Mar 8, 2023 · 1 comment
Open

x/pkgsite: source files links for stdlibs are incorrect in local mode #58923

hyangah opened this issue Mar 8, 2023 · 1 comment
Assignees
@findleyr
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 8, 2023 •
edited

cmd/pkgsite version @ 0a30e374544fc794cc1769dd04254f5be9b62c68 (2023-03-01T13:51:50Z)

Repro:
run pkgsite
visit http://localhost:8080/time (it may take some time to index stdlib)
From "Source Files" section, click "format.go" and see the link is invalid.

I started pkgsite from my pkgsite project directory checked out at /Users/hakim/projects/pkgsite, and the link is "http://localhost:8080/files/Users/hakim/projects/pkgsite/golang.org/x/pkgsite/time/format.go", a strange combination of the process wd + main module path + "/time/format.go".

Probably related: the "Repository" info is incorrect.

image
@cagedmantis cagedmantis added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Mar 8, 2023
@cagedmantis cagedmantis added this to the Backlog milestone Mar 8, 2023
@bcmills bcmills changed the title cmd/pkgsite: source files links for stdlibs are incorrect in local mode x/pkgsite: source files links for stdlibs are incorrect in local mode Mar 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 8, 2023

Possibly related to (or the same underlying cause as) #57742?

@findleyr findleyr self-assigned this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@cagedmantis @hyangah @bcmills @findleyr