Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestCacheCoverage failures #58919

Closed
gopherbot opened this issue Mar 7, 2023 · 6 comments
Closed

cmd/go: TestCacheCoverage failures #58919

gopherbot opened this issue Mar 7, 2023 · 6 comments
Assignees
@bcmills
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Mar 7, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "cmd/go" && test == "TestCacheCoverage" && `test timed out while running command`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCacheCoverage (125.29s)
    go_test.go:2388: running testgo [test -cover -short strings]
    go_test.go:2388: standard output:
    go_test.go:2388: ok  	strings	5.489s	coverage: 97.7% of statements

    go_test.go:2389: running testgo [test -cover -short math strings]
    exec.go:146: test timed out while running command: /tmp/buildlet/tmp/cmd-go-test-2779377144/tmpdir69193264/testbin/go test -cover -short math strings
    go_test.go:2389: standard error:
    go_test.go:2389: SIGQUIT: quit
        PC=0x7ff81f8423ea m=0 sigcode=0
...
panic: test timed out after 9m0s
running tests:
	TestTestCache (2m0s)

goroutine 11740 [running]:
panic({0x1a97b40, 0xc0001c2240})
	/tmp/buildlet/go/src/runtime/panic.go:987 +0x3bb fp=0xc0002b7f18 sp=0xc0002b7e58 pc=0x10888db
testing.(*M).startAlarm.func1()
	/tmp/buildlet/go/src/testing/testing.go:2241 +0x219 fp=0xc0002b7fe0 sp=0xc0002b7f18 pc=0x11f90b9
runtime.goexit()
	/tmp/buildlet/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0002b7fe8 sp=0xc0002b7fe0 pc=0x10c1321
created by time.goFunc
	/tmp/buildlet/go/src/time/sleep.go:176 +0x48

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 7, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestCacheCoverage"
2023-02-28 12:45 darwin-amd64-race go@aef8a8cd cmd/go.TestCacheCoverage (log) 
--- FAIL: TestCacheCoverage (125.29s)
    go_test.go:2388: running testgo [test -cover -short strings]
    go_test.go:2388: standard output:
    go_test.go:2388: ok  	strings	5.489s	coverage: 97.7% of statements

    go_test.go:2389: running testgo [test -cover -short math strings]
    exec.go:146: test timed out while running command: /tmp/buildlet/tmp/cmd-go-test-2779377144/tmpdir69193264/testbin/go test -cover -short math strings
    go_test.go:2389: standard error:
    go_test.go:2389: SIGQUIT: quit
        PC=0x7ff81f8423ea m=0 sigcode=0
...
panic: test timed out after 9m0s
running tests:
	TestTestCache (2m0s)

goroutine 11740 [running]:
panic({0x1a97b40, 0xc0001c2240})
	/tmp/buildlet/go/src/runtime/panic.go:987 +0x3bb fp=0xc0002b7f18 sp=0xc0002b7e58 pc=0x10888db
testing.(*M).startAlarm.func1()
	/tmp/buildlet/go/src/testing/testing.go:2241 +0x219 fp=0xc0002b7fe0 sp=0xc0002b7f18 pc=0x11f90b9
runtime.goexit()
	/tmp/buildlet/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0002b7fe8 sp=0xc0002b7fe0 pc=0x10c1321
created by time.goFunc
	/tmp/buildlet/go/src/time/sleep.go:176 +0x48

— watchflakes

@bcmills bcmills self-assigned this Mar 7, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Mar 7, 2023
@bcmills bcmills added this to the Go1.21 milestone Mar 7, 2023
@bcmills bcmills mentioned this issue Mar 7, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/474137 mentions this issue: cmd/go: don't run slow tests on non-longtest builders

@gopherbot
Copy link
Author

Change https://go.dev/cl/474137 mentions this issue: cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestCacheCoverage" && `test timed out while running command`
2023-03-01 18:01 darwin-amd64-race go@230765a1 cmd/go.TestCacheCoverage (log) 
--- FAIL: TestCacheCoverage (25.86s)
    go_test.go:2388: running testgo [test -cover -short strings]
    exec.go:146: test timed out while running command: /tmp/buildlet/tmp/cmd-go-test-2811279691/tmpdir910072097/testbin/go test -cover -short strings
    go_test.go:2388: standard error:
    go_test.go:2388: SIGQUIT: quit
        PC=0x7ff812e313ea m=0 sigcode=0

        rax    0x104
        rbx    0x4adb600
        rcx    0x7ff7bfeff118
        rdx    0x6b00
        rdi    0x20f4c80
        rsi    0x740100007500
        rbp    0x7ff7bfeff1c0
        rsp    0x7ff7bfeff118
        r8     0x0
        r9     0xa0
        r10    0x0
        r11    0x246
        r12    0x16
        r13    0x0
        r14    0x740100007500
        r15    0x6b00
        rip    0x7ff812e313ea
        rflags 0x247
        cs     0x7
        fs     0x0
        gs     0x0

    go_test.go:2388: go [test -cover -short strings] failed unexpectedly in /tmp/buildlet/go/src/cmd/go: exit status 2

— watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/474580 mentions this issue: [release-branch.go1.20] cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link
Author

Change https://go.dev/cl/474581 mentions this issue: [release-branch.go1.19] cmd/go: avoid running slow tests on non-longtest builders

gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.19] cmd/go: avoid running slow tests on non-longt…
fbf4c04 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58937.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474581
gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.20] cmd/go: avoid running slow tests on non-longt…
b852f39 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58938.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474580
@bcmills bcmills mentioned this issue Apr 6, 2023
Closed
@golang golang locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot