Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: invalid SlowBots in TRY= comments are silently ignored #58902

Closed
bcmills opened this issue Mar 6, 2023 · 3 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 6, 2023

In https://go-review.git.corp.google.com/c/go/+/465805/6#message-b69a437c43e08f518fc3ffb4de60cc525f9ee9ef, I typo'd a TRY= line, listing a valid builder name (longtest) along with an invalid one (windows-awd64-longtest).

The Gopher Robot ran only the longtest builder, and happily added a TryBot-Result along with a list of slowbots that included only the valid one.

Especially given that the TryBot+1 now feeds into submitting auto-submit CLs, it should not ignore invalid builders. Instead, it should reply on the CL with an explicit error if the TRY= line contains an invalid name.

This is related to #41831, but perhaps easier to resolve.

(attn @golang/release)

@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Mar 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2023
@mauri870
Copy link
Member

@gopherbot, assign @mauri870

@gopherbot
Copy link

Change https://go.dev/cl/528055 mentions this issue: cmd/coordinator: report invalid SlowBots in TRY comments

@mauri870
Copy link
Member

Looks like this is already deployed, a quick test shows that it is working as intended:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants