-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: linux-amd64-perf repeatedly failing on x/tools with "error committing perfdata file: upload failed: 500 Internal Server Error no valid benchmark lines found" #58875
Comments
cc @findleyr There should be runs of FWIW, https://build.golang.org/?repo=golang.org%2fx%2ftools looks clean now, no fails. Is it possible to see more of the history at subrepo commit c0742f5? |
Ah, the failures on the farmer are 1.19 and 1.20 release branch commits. It seems that the dashboard can't display history for those at all? :( https://build.golang.org/?repo=golang.org%2Fx%2Ftools&branch=release-branch.go1.20 |
This was broken by https://go-review.git.corp.google.com/c/tools/+/468940/10/gopls/internal/regtest/bench/definition_test.go (cc @findleyr), which changed the name of the benchmark from BenchmarkGoToDefinition to BenchmarkDefinition. x/benchmarks is configured to benchmark only BenchmarkGoToDefinition: https://cs.opensource.google/go/x/benchmarks/+/master:cmd/bench/gotest.go;l=47. Switching to a new name is painful, because x/benchmarks is going to test tip x/tools vs the previous gopls release, which currently have different names for this benchmark. The simplest way to make things work would be to run all benchmarks in the package rather than filtering them, though the perf dashboard will still have a disconnect where the benchmark changes name. |
FYI, this failure is blocking tagging of x/tools. Not saying it makes sense, but that's how I wrote it. |
On it. |
Change https://go.dev/cl/473756 mentions this issue: |
The fix also needs https://go.dev/cl/473677, which I just submitted. Builders should now succeed. |
This fixes a breakage due to renaming of BenchmarkGoToDefinition, and provides a means for us to configure the benchmarks run by x/benchmark in the future. Also add some documentation, and refactor somewhat. Remove -v for gopls benchmarks, as that prints noisy results. Fixes golang/go#58875 Change-Id: I862ace4af029b8042d50467567bf314b2e5521ae
Also add some documentation, and refactor somewhat. Fixes golang/go#58875 Change-Id: I862ace4af029b8042d50467567bf314b2e5521ae
This fixes a breakage due to renaming of BenchmarkGoToDefinition, and provides a means for us to configure the benchmarks run by x/benchmark in the future. Also add some documentation, and refactor somewhat. Remove -v for gopls benchmarks, as that prints noisy results. Fixes golang/go#58875 Change-Id: I862ace4af029b8042d50467567bf314b2e5521ae
This fixes a breakage due to renaming of BenchmarkGoToDefinition, and provides a means for us to configure the benchmarks run by x/benchmark in the future. Also add some documentation, and refactor somewhat. Fixes golang/go#58875 Change-Id: I862ace4af029b8042d50467567bf314b2e5521ae
Looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the linux-amd64-perf builder column has some "ok" rows but most are empty.
At https://farmer.golang.org/#completed right now there are many repeated recent failures:
It fails on the "upload_bench_results" step:
Full Log
Also relevant is that this builder is currently considered as one that must be passing for purpose of golang.org/x tagging (CC @heschi):
CC @golang/release, @prattmic, @mknyszek.
The text was updated successfully, but these errors were encountered: