cmd/gopherbot: move "ping-early-issues" task to relui #58856
Comments
dmitshur
added
Builders
|
Change https://go.dev/cl/473160 mentions this issue: |
|
Change https://go.dev/cl/473159 mentions this issue: |
Do this here first to make the diff easier to see. The next CL in stack moves it to relui. Notably the GraphQL implementation here is missing the "avoid duplicate comments" safety net implemented in maintner-powered addGitHubComment. With maintner, it costs no API calls to check all comments in a GitHub issue for a past comment. When using the GitHub API, this unfortunately costs more API quota and needs to be implemented explicitly, adding to the verbosity of the implementation. For golang/go#58856. Change-Id: I2757697e561cb00d041f65ba846d902c0de35e22 Reviewed-on: https://go-review.googlesource.com/c/build/+/473159 Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
When adding a dedicated relui workflow, it was tempting to make it fancy with each issue being a sub-task, etc. But we wouldn't want that if/when this task joins others as part of a "reopen the dev tree" workflow, so keep it a simple atomic (and safe to re-run) task. This is similar to how pushing issues or checking for release blockers is one atomic task. For golang/go#58856. Change-Id: Idc8ef3cd62b7bb98c97b37d38ef9cdc2beccc24c Reviewed-on: https://go-review.googlesource.com/c/build/+/473160 Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
|
This is done and worked to ping early issues in the Go 1.22 milestone recently. This was also a bit of an exercise to see if GitHub's GraphQL API can help when moving away from maintner as a dependency. My conclusion is that it helps a bit, but using maintner (if it works) is still so much nicer and simpler. There's a harmless TODO in code to decide "if it's worth moving the GraphQL query/mutation". I had the idea of possibly moving the query into GitHubClientInterface, but that really means moving the entire task's implementation there. I don't think it's worth it now, but can revisit this later. |
Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in
gopherbotthat needs to be explicitly run with-only-run=ping-early-issuesflag (and provide a URL of the reopening announcement via theopenTreeURLsmap).Now that we have relui, this task can move there. Not only is it slightly easier to trigger the task via a web UI, it also eliminates the need of setting up credentials for running
goperboton a local workstation. Having it in relui also opens future opportunities like eventually making it a part of a larger "reopen tree for development" workflow, etc.This is the tracking issue for moving the task to relui. To avoid bringing in the maintner dependency into relui, I'll also rewrite it to use GitHub API v4 (GraphQL) instead and use it as an opportunity to see what that looks like.
CC @golang/release.
The text was updated successfully, but these errors were encountered: