Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: update documentation and processes for new release timeline #58820

Closed
6 of 7 tasks
heschi opened this issue Mar 1, 2023 · 3 comments
Closed
6 of 7 tasks

x/build: update documentation and processes for new release timeline #58820

heschi opened this issue Mar 1, 2023 · 3 comments
Assignees
@heschi
Labels
Builders x/build issues (builders, bots, dashboards) Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@heschi
Copy link
Contributor

heschi commented Mar 1, 2023 •
edited

For the 1.20 cycle we decided to freeze later, skip the beta releases, and reopen the tree for development early. We didn't document any of that because it was just an experiment. Now we've decided to make the changes permanent, so we should document the updated timeline, and fix any process issues.

One complaint during the early thaw was that it was hard to know how to do cherrypicks. We filed #57854 to ease the process, but people still found it confusing and filed backport issues. For the next cycle, we intend to allow all approvers to submit to the release branch for a while, so that the process is completely self-service.

Also, now that we're consistently hitting our target release dates, a new problem has emerged: doing minor releases and major releases on the same week is tough, especially when there are security fixes in the minor releases. We need to find some way to avoid this recurring conflict. One idea is to do the GA mid-month, though that means the release cycle will be about two weeks longer.

Items:

  • Decide on major release timing
  • Update https://github.com/golang/go/wiki/Go-Release-Cycle
    • Remove discussion of beta releases
    • Fix the dates of everything
    • Document the early thaw, and how to cherrypick CLs during the initial part.
  • Design and implement Gerrit permission changes to enable easier cherrypicks during the early thaw.
    • Bonus points: automate the permission changes.

cc @golang/release
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 1, 2023
@heschi heschi added this to the Go1.21 milestone Mar 1, 2023
@heschi heschi self-assigned this Mar 1, 2023
@gopherbot gopherbot added Builders x/build issues (builders, bots, dashboards) Documentation labels Mar 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/474675 mentions this issue: cmd/releaseschedule: create

gopherbot pushed a commit to golang/build that referenced this issue Mar 9, 2023
@heschi @gopherbot
cmd/releaseschedule: create
65cc91d 
Add a program that generates the release schedule diagram used on the
release schedule wiki.

For golang/go#58820

Change-Id: I8117e28704ecad2da016bcd5b0f34cb198d0e440
Reviewed-on: https://go-review.googlesource.com/c/build/+/474675
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
crisman added a commit to crisman/golang_build that referenced this issue Mar 27, 2023
@crisman
cmd/releaseschedule: add dark mode aware svg css
8580eb7 
The SVG image used on https://go.dev/s/release is mostly unreadable if
viewed in dark mode (set in OS, browser, or github settings) as the black
text/lines on dark background are too close in color. It would be possible to
set a background color on the svg, but I think the better answer is CSS in
the SVG which is @media aware of prefers-color-scheme:dark to switch the
colors from black to white.

Remove the explicit style on line/path and add css for text/line/path which
is black but in dark mode changes to white.

Updates golang/go#58820
Fixes golang/go#59275
@crisman crisman mentioned this issue Mar 27, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/479575 mentions this issue: cmd/releaseschedule: add dark mode aware svg css

gopherbot pushed a commit to golang/build that referenced this issue Mar 27, 2023
@crisman @gopherbot
cmd/releaseschedule: add dark mode aware svg css
be32736 
The SVG image used on https://go.dev/s/release is mostly unreadable
if viewed in dark mode (set in OS, browser, or github settings) as
the black text/lines on dark background are too close in color.
It would be possible to set a background color on the svg, but I
think the better answer is CSS in the SVG which is @media aware of
prefers-color-scheme:dark to switch the colors from black to white.

Remove the explicit style on line/path and add css for text/line/path
which is black but in dark mode changes to white.

Updates golang/go#58820
Fixes golang/go#59275

Change-Id: I6cd364891eeb27c76db21c21b16d2d12e6b78892
GitHub-Last-Rev: 8580eb7
GitHub-Pull-Request: #63
Reviewed-on: https://go-review.googlesource.com/c/build/+/479575
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@heschi
Copy link
Contributor Author

heschi commented May 24, 2023

Everything's done except the automation. Good enough for this cycle.

@heschi heschi closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heschi heschi

Labels
Builders x/build issues (builders, bots, dashboards) Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@gopherbot @heschi