Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/watchflakes: should report broken or missing builders #58819

Open
heschi opened this issue Mar 1, 2023 · 7 comments
Open

x/build/cmd/watchflakes: should report broken or missing builders #58819

heschi opened this issue Mar 1, 2023 · 7 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Mar 1, 2023

@rsc says that watchflakes has code to detect broken builders. It would be nice to turn that awareness into issues, especially for breakages on x/ repos, where problems tend to go unnoticed for a long time.

cc @cherrymui, @bcmills

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 1, 2023
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 1, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 7, 2023

I suggest:

  • If the main repo is broken, watchflakes should automatically file a single issue for all affected builders, and automatically close the issue if/when all of those builders pass again.
  • If only specific repo is broken, watchflakes should automatically file a single issue for all affected builders, and automatically close it if/when they pass again.
  • If watchflakes posts more than N (5?) failures for a single builder, GOOS, or GOARCH in a 24h period, it should file an issue with a default rule for the affected builder, GOOS, or GOARCH (to avoid spamming the issue tracker with duplicates). (build: failures on illumos-amd64 #59379 is an example of such an issue.)

@bcmills
Copy link
Contributor

bcmills commented Aug 9, 2023

I just filed #61891 for a runtime/pprof test failure introduced about a week ago. It would be nice not to have to file issues like that manually.

@bcmills
Copy link
Contributor

bcmills commented Aug 18, 2023

Some more examples of test failures that had to be reported manually:

As far as I can tell those failures were only noticed because I happened to look at the dashboard this morning.

@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2023

More examples this week:

@bcmills
Copy link
Contributor

bcmills commented Sep 26, 2023

@bcmills
Copy link
Contributor

bcmills commented Oct 30, 2023

@cherrymui
Copy link
Member

I found the failure shortly after I submitted the CL, and sent a CL to fix. I didn't file an issue.

@dmitshur dmitshur changed the title x/build/cmd/watchflakes: should report broken builders x/build/cmd/watchflakes: should report broken or missing builders Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Planned
Development

No branches or pull requests

4 participants