Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestIssue51759 has started to fail on darwin-amd64-10_15 #58812

Closed
dmitshur opened this issue Mar 1, 2023 · 3 comments
Closed

crypto/x509: TestIssue51759 has started to fail on darwin-amd64-10_15 #58812

dmitshur opened this issue Mar 1, 2023 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023 •
edited

As of CL 472295 (which fixed #58791), TestIssue51759 is failing on darwin-amd64-10_15 (only) with:

--- FAIL: TestIssue51759 (0.26s)
    --- FAIL: TestIssue51759/leaf (0.09s)
        verify_test.go:1874: unexpected error: want "invalid leaf certificate", got "x509: “derpkey8dc58100b2493614ee1692831a461f3f4dd3f9b3b088e244f887f81b4906ac26” certificate is using a broken key size"
    --- FAIL: TestIssue51759/intermediate (0.16s)
        verify_test.go:1891: unexpected error: want "SecCertificateCreateWithData: invalid certificate", got <nil>
FAIL
FAIL	crypto/x509	0.640s

See https://build.golang.org/log/530275d3304d16e7558722aa52db917717c82614. (Note that the actual failure is more verbose; I used CL 472097 to produce the shorter one above.)

CC @rolandshoemaker (also CC @bcmills FYI).
@dmitshur dmitshur added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Mar 1, 2023
@dmitshur dmitshur added this to the Go1.21 milestone Mar 1, 2023
@dmitshur dmitshur changed the title crypto/x509: TestSystemVerify has started to fail on darwin-amd64-10_15 crypto/x509: TestIssue51759 has started to fail on darwin-amd64-10_15 Mar 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/472496 mentions this issue: crypto/x509: fix broken tests

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/472618 mentions this issue: [release-branch.go1.20] crypto/x509: fix broken tests

@gopherbot
Copy link

Change https://go.dev/cl/472617 mentions this issue: [release-branch.go1.19] crypto/x509: fix broken tests

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.20] crypto/x509: fix broken tests
9629fa1 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates #58791
Updates #58812
Fixes #58811

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472618
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.19] crypto/x509: fix broken tests
0d288f9 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates #58791
Updates #58812
Fixes #58810

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472617
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@rolandshoemaker @romaindoumenc
[release-branch.go1.20] crypto/x509: fix broken tests
cefd526 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates golang#58791
Updates golang#58812
Fixes golang#58811

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472618
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@bcmills bcmills mentioned this issue Dec 12, 2023
Closed
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot