Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestSystemVerify consistently failing [1.19 backport] #58810

Closed
gopherbot opened this issue Mar 1, 2023 · 6 comments
Closed

crypto/x509: TestSystemVerify consistently failing [1.19 backport] #58810

gopherbot opened this issue Mar 1, 2023 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.19.7

Comments

@gopherbot
Copy link

@dmitshur requested issue #58791 to be considered for backport to the next 1.19 minor release.

@gopherbot Please backport at minimum the Windows text fix aspect of this issue.

This is needed to fix failing tests on release branches.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 1, 2023
@gopherbot gopherbot mentioned this issue Mar 1, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.7 milestone Mar 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023

This test is not failing on Windows builders on release-branch.go1.19. Either there's no problem (i.e., TestSystemVerify was modified in a way that needed the fix only in Go 1.20) or perhaps it's because -oldcc Windows builders are used on release-branch.go1.19.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023 •
edited

Confirmed that the problem reproduces on an updated Windows 11 device with Go 1.19.x, and the patch fixes it.

@gopherbot
Copy link
Author

Change https://go.dev/cl/472615 mentions this issue: [release-branch.go1.19] crypto/x509: fix system root tests + darwin intermediate handling

@gopherbot
Copy link
Author

Change https://go.dev/cl/472617 mentions this issue: [release-branch.go1.19] crypto/x509: fix broken tests

@gopherbot
Copy link
Author

Closed by merging 0d288f9 to release-branch.go1.19.

@gopherbot
Copy link
Author

Closed by merging 21e451e to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.19] crypto/x509: fix system root tests + darwin i…
21e451e 
…ntermediate handling

On Windows, replace tests which rely on a root that expired last year.
On Darwin fix an test which wasn't testing the expected behavior, and
fix the behavior which was broken.

Updates #58791
Fixes #58810

Change-Id: I771175b9e123b8bb0e4efdf58cc2bb93aa94fbae
Reviewed-on: https://go-review.googlesource.com/c/go/+/472295
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
(cherry picked from commit bb8f9a6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472615
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.19] crypto/x509: fix broken tests
0d288f9 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates #58791
Updates #58812
Fixes #58810

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472617
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@cherrymui cherrymui mentioned this issue May 10, 2023
Closed
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.19.7
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot