Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: Incorrect documentation for ParsePKCS8PrivateKey [1.20 backport] #58793

Closed
gopherbot opened this issue Feb 28, 2023 · 3 comments
Closed

crypto/x509: Incorrect documentation for ParsePKCS8PrivateKey [1.20 backport] #58793

gopherbot opened this issue Feb 28, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.20.2

Comments

@gopherbot
Copy link

@FiloSottile requested issue #58789 to be considered for backport to the next 1.20 minor release.

Good catch, thank you! @gopherbot please open a backport issue to Go 1.20, this is a confusing documentation bug and it would be nice to get the fix live on pkg.go.dev before the next major release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 28, 2023
@gopherbot gopherbot mentioned this issue Feb 28, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.2 milestone Feb 28, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/472415 mentions this issue: [release-branch.go1.20] crypto/x509: fix ParsePKCS8PrivateKey comment

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023

No backport needed for Go 1.19 because this issue isn't present in that version.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2023
@gopherbot
Copy link
Author

Closed by merging bdd86bd to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.20] crypto/x509: fix ParsePKCS8PrivateKey comment
bdd86bd 
Updates #58789.
Fixes #58793.

Change-Id: I91cdd20c6d4f05baaacd6a38717aa7bed6682573
Reviewed-on: https://go-review.googlesource.com/c/go/+/472155
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit ec26277)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472415
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@rolandshoemaker @romaindoumenc
[release-branch.go1.20] crypto/x509: fix ParsePKCS8PrivateKey comment
e414da4 
Updates golang#58789.
Fixes golang#58793.

Change-Id: I91cdd20c6d4f05baaacd6a38717aa7bed6682573
Reviewed-on: https://go-review.googlesource.com/c/go/+/472155
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit ec26277)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472415
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.20.2
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot