Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestSystemVerify consistently failing #58791

Closed
bcmills opened this issue Feb 28, 2023 · 17 comments
Closed

crypto/x509: TestSystemVerify consistently failing #58791

bcmills opened this issue Feb 28, 2023 · 17 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 28, 2023 •
edited 

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"

https://build.golang.org/log/97b5cac923dc9079392efd9637b9fffa8b9f7592:

--- FAIL: TestSystemVerify (1.59s)
    --- FAIL: TestSystemVerify/Valid (0.10s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
FAIL
FAIL	crypto/x509	2.845s

(attn @golang/security @dmitshur)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Windows release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Feb 28, 2023
@bcmills bcmills added this to the Go1.21 milestone Feb 28, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Feb 28, 2023

I think this is something to do with an expiration — all of the builders started failing at once, even on TryBots at older base CLs (https://storage.googleapis.com/go-build-log/cd3d6904/windows-386-2016_967987aa.log).

@bcmills bcmills pinned this issue Feb 28, 2023
@gopherbot
Copy link

Change https://go.dev/cl/472295 mentions this issue: crypto/x509: fix system root tests + darwin intermediate handling

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 28, 2023
@gopherbot
Copy link

Change https://go.dev/cl/472097 mentions this issue: crypto/x509: avoid nil dereference in tests

@bcmills bcmills unpinned this issue Mar 1, 2023
@bcmills bcmills mentioned this issue Mar 1, 2023
Closed
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
2023-02-28 19:35 windows-amd64-2016 go@4a9c84d0 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.44s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 19:35 windows-arm64-11 go@4a9c84d0 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 21:59 windows-amd64-race go@ec26277a crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.43s)
    --- FAIL: TestSystemVerify/Valid (0.12s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 22:18 windows-amd64-2016 go@65fa9ce8 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.52s)
    --- FAIL: TestSystemVerify/Valid (0.11s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.01s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 22:18 windows-amd64-race go@65fa9ce8 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.66s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.01s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 22:18 windows-arm64-11 go@65fa9ce8 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 23:42 windows-amd64-2016 go@0384235a crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.74s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.01s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 23:42 windows-amd64-race go@0384235a crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.62s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 23:42 windows-arm64-11 go@0384235a crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.03s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]

— watchflakes

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023

@gopherbot Please backport at minimum the Windows text fix aspect of this issue.

This is needed to fix failing tests on release branches.

This was referenced Mar 1, 2023
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #58810 (for 1.19), #58811 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@bcmills bcmills removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Mar 1, 2023
@dmitshur dmitshur mentioned this issue Mar 1, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/472496 mentions this issue: crypto/x509: fix broken tests

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker
crypto/x509: fix broken tests
cf3d065 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for.

Updates #58791
Fixes #58812

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/472615 mentions this issue: [release-branch.go1.19] crypto/x509: fix system root tests + darwin intermediate handling

@gopherbot
Copy link

Change https://go.dev/cl/472616 mentions this issue: [release-branch.go1.20] crypto/x509: fix system root tests + darwin intermediate handling

@gopherbot
Copy link

Change https://go.dev/cl/472618 mentions this issue: [release-branch.go1.20] crypto/x509: fix broken tests

@gopherbot
Copy link

Change https://go.dev/cl/472617 mentions this issue: [release-branch.go1.19] crypto/x509: fix broken tests

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.20] crypto/x509: fix system root tests + darwin i…
3243f93 
…ntermediate handling

On Windows, replace tests which rely on a root that expired last year.
On Darwin fix an test which wasn't testing the expected behavior, and
fix the behavior which was broken.

Updates #58791
Fixes #58811

Change-Id: I771175b9e123b8bb0e4efdf58cc2bb93aa94fbae
Reviewed-on: https://go-review.googlesource.com/c/go/+/472295
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
(cherry picked from commit bb8f9a6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472616
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.20] crypto/x509: fix broken tests
9629fa1 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates #58791
Updates #58812
Fixes #58811

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472618
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.19] crypto/x509: fix system root tests + darwin i…
21e451e 
…ntermediate handling

On Windows, replace tests which rely on a root that expired last year.
On Darwin fix an test which wasn't testing the expected behavior, and
fix the behavior which was broken.

Updates #58791
Fixes #58810

Change-Id: I771175b9e123b8bb0e4efdf58cc2bb93aa94fbae
Reviewed-on: https://go-review.googlesource.com/c/go/+/472295
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
(cherry picked from commit bb8f9a6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472615
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Mar 1, 2023
@rolandshoemaker @gopherbot
[release-branch.go1.19] crypto/x509: fix broken tests
0d288f9 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates #58791
Updates #58812
Fixes #58810

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472617
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot gopherbot reopened this Mar 1, 2023
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
2023-03-01 18:06 windows-arm64-11 go@600d372f crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.06s)
    --- FAIL: TestSystemVerify/Valid (0.04s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]

— watchflakes

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023

Thanks watchflakes, but commit 600d37 is before the fix in commit 21e451e.

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
2023-03-01 17:28 windows-386-2016 go@bdd86bda crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.89s)
    --- FAIL: TestSystemVerify/Valid (0.22s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 17:28 windows-amd64-2016 go@bdd86bda crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (1.48s)
    --- FAIL: TestSystemVerify/Valid (0.10s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 17:28 windows-arm64-11 go@bdd86bda crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.06s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:06 windows-386-2016 go@d2d0ee20 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.58s)
    --- FAIL: TestSystemVerify/Valid (0.25s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.01s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.03s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:06 windows-amd64-2016 go@d2d0ee20 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.31s)
    --- FAIL: TestSystemVerify/Valid (0.12s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:06 windows-arm64-11 go@d2d0ee20 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]

— watchflakes

@dmitshur dmitshur closed this as completed Mar 1, 2023
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
2023-03-01 17:28 windows-amd64-longtest go@bdd86bda crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.72s)
    --- FAIL: TestSystemVerify/Valid (0.12s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 17:28 windows-amd64-race go@bdd86bda crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.58s)
    --- FAIL: TestSystemVerify/Valid (0.15s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.01s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.03s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:06 windows-amd64-longtest go@d2d0ee20 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.53s)
    --- FAIL: TestSystemVerify/Valid (0.11s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.01s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:06 windows-amd64-race go@d2d0ee20 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.66s)
    --- FAIL: TestSystemVerify/Valid (0.11s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]

— watchflakes

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@rolandshoemaker @romaindoumenc
[release-branch.go1.20] crypto/x509: fix system root tests + darwin i…
23b13df 
…ntermediate handling

On Windows, replace tests which rely on a root that expired last year.
On Darwin fix an test which wasn't testing the expected behavior, and
fix the behavior which was broken.

Updates golang#58791
Fixes golang#58811

Change-Id: I771175b9e123b8bb0e4efdf58cc2bb93aa94fbae
Reviewed-on: https://go-review.googlesource.com/c/go/+/472295
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
(cherry picked from commit bb8f9a6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472616
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@rolandshoemaker @romaindoumenc
[release-branch.go1.20] crypto/x509: fix broken tests
cefd526 
Convert TestUnknownAuthorityError to use subtests, avoiding continuing
the test after an unrecoverable failure.

Skip TestIssue51759 on pre-macOS 11 builders, which don't enforce the
behavior we were testing for. Also only enable the test on builders.

Updates golang#58791
Updates golang#58812
Fixes golang#58811

Change-Id: I4e3e5bc371aa139d38052184c8232f8cb564138f
Reviewed-on: https://go-review.googlesource.com/c/go/+/472496
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit cf3d065)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472618
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && pkg == "crypto/x509" && test == "TestSystemVerify"
2023-02-28 18:46 windows-arm64-11 go@9aaaedbb crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 18:50 windows-arm64-11 go@89c3f7c1 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 18:50 windows-amd64-longtest go@af758177 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.43s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-02-28 18:50 windows-arm64-11 go@454198ab crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:00 windows-arm64-11 go@8417168d crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:01 windows-amd64-2016 go@230765a1 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.42s)
    --- FAIL: TestSystemVerify/Valid (0.13s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:01 windows-amd64-longtest go@230765a1 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.45s)
    --- FAIL: TestSystemVerify/Valid (0.15s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.03s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:01 windows-amd64-race go@230765a1 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.74s)
    --- FAIL: TestSystemVerify/Valid (0.12s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.02s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]
2023-03-01 18:01 windows-arm64-11 go@230765a1 crypto/x509.TestSystemVerify (log) 
--- FAIL: TestSystemVerify (0.04s)
    --- FAIL: TestSystemVerify/Valid (0.02s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/MixedCase (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/HostnameMismatch (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/IPMissing (0.00s)
        verify_test.go:378: error was not a HostnameError: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/Expired (0.00s)
        verify_test.go:388: error was not Expired: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/RootInIntermediates (0.00s)
        verify_test.go:479: unexpected error: x509: certificate signed by unknown authority
    --- FAIL: TestSystemVerify/SHA-384 (0.00s)
        verify_test.go:514: Got 0 matches instead of 1 for expected chain [api.moip.com.br COMODO RSA Extended Validation Secure Server CA COMODO RSA Certification Authority AddTrust External CA Root]

— watchflakes

@rolandshoemaker
Copy link
Member

These all appear old.

@golang golang locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dmitshur @rolandshoemaker @bcmills @gopherbot