Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: ICE on method value involving imported anonymous interface [1.20 backport] #58776

Closed
gopherbot opened this issue Feb 27, 2023 · 3 comments
Closed

cmd/compile: ICE on method value involving imported anonymous interface [1.20 backport] #58776

gopherbot opened this issue Feb 27, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.2

Comments

@gopherbot
Copy link

@mdempsky requested issue #58563 to be considered for backport to the next 1.20 minor release.

@gopherbot Please backport to 1.20.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 27, 2023
@gopherbot gopherbot mentioned this issue Feb 27, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 27, 2023
@gopherbot gopherbot added this to the Go1.20.2 milestone Feb 27, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2023

@mdempsky Please add a short backport rationale to this backport issue (see https://go.dev/wiki/MinorReleases; "The issue should include a link to the original issue and a short rationale about why the backport might be needed."). Thanks.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/472620 mentions this issue: [release-branch.go1.20] cmd/compile: relax overly strict assertion

@gopherbot
Copy link
Author

Closed by merging 26eeaec to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@mdempsky @gopherbot
[release-branch.go1.20] cmd/compile: relax overly strict assertion
26eeaec 
The assertion here was to make sure the newly constructed and
typechecked expression selected the same receiver-qualified method,
but in the case of anonymous receiver types we can actually end up
with separate types.Field instances corresponding to each types.Type
instance. In that case, the assertion spuriously failed.

The fix here is to relax and assertion and just compare the method's
name and type (including receiver type).

Fixes #58776.

Change-Id: I67d51ddb020e6ed52671473c93fc08f283a40886
Reviewed-on: https://go-review.googlesource.com/c/go/+/471676
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 37a2004)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472620
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@mdempsky @romaindoumenc
[release-branch.go1.20] cmd/compile: relax overly strict assertion
cd0581b 
The assertion here was to make sure the newly constructed and
typechecked expression selected the same receiver-qualified method,
but in the case of anonymous receiver types we can actually end up
with separate types.Field instances corresponding to each types.Type
instance. In that case, the assertion spuriously failed.

The fix here is to relax and assertion and just compare the method's
name and type (including receiver type).

Fixes golang#58776.

Change-Id: I67d51ddb020e6ed52671473c93fc08f283a40886
Reviewed-on: https://go-review.googlesource.com/c/go/+/471676
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 37a2004)
Reviewed-on: https://go-review.googlesource.com/c/go/+/472620
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.2
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot