Skip to content

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.20 backport] #58774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 27, 2023 · 6 comments
Closed

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.20 backport] #58774

gopherbot opened this issue Feb 27, 2023 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.2

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #58714 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. These failures also occur on at least release-branch.go1.20.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 27, 2023
@gopherbot gopherbot mentioned this issue Feb 27, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 27, 2023
@gopherbot gopherbot added this to the Go1.20.2 milestone Feb 27, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/471599 mentions this issue: [release-branch.go1.20] syscall: fix invalid unsafe.Pointer conversion on Windows

@bcmills
Copy link
Contributor

bcmills commented Feb 28, 2023 •
edited
Loading

This is causing relatively frequent test failures on the 1.20 release branch. I'm not sure why it started so recently, though. 🤔

@cuonglm
Copy link
Member

cuonglm commented Feb 28, 2023 •
edited
Loading

This is causing relatively frequent test failures on the 1.20 release branch. I'm not sure why it started so recently, though. thinking

Could you point me out where, I can't see test fail on builder dashboard?

@bcmills
Copy link
Contributor

bcmills commented Feb 28, 2023

The failures watchflakes has found are in x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd:

I'm not sure why that test in particular would uncover it, though. (Maybe something about when and where it calls Environ?)

@cuonglm
Copy link
Member

cuonglm commented Feb 28, 2023

TestRunGovulncheckStd

I see.

It could also be how big the environment for that test? 1 << 24 is roughly 16 MB, not sure the env can be big like that.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging d2d0ee2 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@cuonglm @gopherbot
[release-branch.go1.20] syscall: fix invalid unsafe.Pointer conversio…
d2d0ee2 
…n on Windows

Updates #58714
Fixes #58774

Change-Id: Ifa5c059ed5e358ed98aee7e83b95dd1806b535f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/471335
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit de8c999)
Reviewed-on: https://go-review.googlesource.com/c/go/+/471599
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@cuonglm @romaindoumenc
[release-branch.go1.20] syscall: fix invalid unsafe.Pointer conversio…

Unverified

This user has not yet uploaded their public signing key.
Learn about vigilant mode
cee0b86 
…n on Windows

Updates golang#58714
Fixes golang#58774

Change-Id: Ifa5c059ed5e358ed98aee7e83b95dd1806b535f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/471335
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit de8c999)
Reviewed-on: https://go-review.googlesource.com/c/go/+/471599
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.2
Development

No branches or pull requests
4 participants
@dmitshur @cuonglm @bcmills @gopherbot