Skip to content

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.19 backport] #58773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 27, 2023 · 3 comments
Closed

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.19 backport] #58773

gopherbot opened this issue Feb 27, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.7

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #58714 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. These failures also occur on at least release-branch.go1.20.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 27, 2023
@gopherbot gopherbot mentioned this issue Feb 27, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 27, 2023
@gopherbot gopherbot added this to the Go1.19.7 milestone Feb 27, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 27, 2023

I'm not entirely sure whether -d=checkptr flags these violations on Windows in Go 1.19.

If it does, we may need to adjust the backport CL to avoid unsafe.Add and unsafe.Slice, which were added in Go 1.17 and might not be available in the bootstrap toolchain for Go 1.19.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/471935 mentions this issue: [release-branch.go1.19] syscall: fix invalid unsafe.Pointer conversion on Windows

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 600d372 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Mar 1, 2023
@cuonglm @gopherbot
[release-branch.go1.19] syscall: fix invalid unsafe.Pointer conversio…
600d372 
…n on Windows

This cherry-pick CL 471335 without using unsafe.{Add,Slice}.

Fixes #58773

Change-Id: Ifa5c059ed5e358ed98aee7e83b95dd1806b535f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/471335
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/471935
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.7
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot